Refactor constants #1094
Merged
Refactor constants #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Kind of. This commit is a bit of a mess, but will help a lot in the future. All stuff related to the extraction of information out of files is now in its own module, and all stuff related to the parsing and handling of copyright lines is also in its own module. The problem caused by this commit is that the tests are incomplete. Previously, not all functions in _util were tested in the understanding that they were just small helper functions for _actual_ functions that are under test. Now, there are public functions in public modules that are not tested, and by chance, all of the remaining _util is currently untested. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_util.pyand__init__.pyare full of constants. I want to clean this up to have better separation of concerns.the current specification.
changed files.