-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Monorepos #332
Conversation
Imaging a [monorepo] like this: ``` monorepo-example ├── project_a │ ├── README.md │ └── .reuse │ └── dep5 ├── project_b │ ├── README.md │ └── .reuse │ └── dep5 └── README.md ``` Without this change, `reuse` is confused that at the root of the project, there is no `.reuse` directory structure. [monorepo]: https://en.wikipedia.org/wiki/Monorepo
Phew, thanks for bringing that up. However, I am a bit afraid of adding this as it would complicate the spec and also the tool. In our spec, we only allow for one .reuse directory: https://reuse.software/spec/#dep5 However, we're working on supporting more flexible files for bulk-licensing stuff that shall soft-deprecate the DEP5 files. See more details here: spdx/spdx-spec#502 If we introduced that, it should solve your issue, and we can dep5 deprecate slowly. What do you think? |
The proposal from https://lists.fsfe.org/pipermail/reuse/2020q3/000085.html sounds good. It would address it. You can close this if you want. |
Thanks for the info. I hope we'll have this implemented soon :) |
I struggled with adopting Quoting myself from my commit message:
It's quite a different approach to licensing management, instead of checking that files have licensing attached it declaratively manages the entire repository licensing. @mxmehl Would you be interested in integrating something like this into Btw, just to clarify: Of course I'm not suggesting that users should write rules in Python, it was just the lowest mental overhead approach while I was hacking on it. |
--root existed even back when I opened fsfe/reuse-tool#332. I just missed that it is enough to fix my use case.
I just noticed that the use case I initially opened this PR for does not need code changes. Using |
Imaging a monorepo like this:
Without this change,
reuse
is confused that at the root of the project, there is no.reuse
directory structure.This PR probably needs discussion before it can be merged. I just went ahead and provided this POC implementation so that we have some code to talk about. At the very least, a test will need to be added. Refer to https://github.com/ypid/latex-packages for a real life (mono)repo for testing.