util: fix parsing of copyrights without year #861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a crash when reuse tries to parse an older Copyright line which has no year token. This resulted in a None dereference when a string was expected. Signed-off-by: Anthony Loiseau <[email protected]>
Signed-off-by: Anthony Loiseau <[email protected]>
|
I think I can see what this PR fixes. Do you have an example for how to trigger the bug, though? Thanks for the patch @anthony-loiseau-act |
|
Sure. I created an issue ticket to properly sort the root issue I reached and fixed by this proposal. This is #866. TLDR: Attempting to add a n SPDX with |
|
Thanks a heap @anthony-loiseau-act ! Added a test in #873 and merged the PR. Excellent eyes spotting and fixing this bug. |
anthony-loiseau-act
deleted the
tmp/16689-fix-reuse-crash-year-parsing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash when reuse tries to parse an older Copyright line which has no year token. This resulted in a None dereference when a string was expected.
Closes #866