Avoid use of private APIs from azure.storage #427
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is designed to fix issue 426, and remove use of private modules from azure.storage - hopefully help avoid future issues like the recent sdk_moniker key error cropping in.
There's two changes here, both of which are pretty minor, but the second of which might need some discussion on whether it's the right approach.
Import switches
BlobPrefix
,BlobBlock
,BlobPoperties
andBlobType
are all exposed as importables straight from azure.storage.blob without needing the private modules, so this is a drop in replacement.Default Block Size
This change might need a little more discussion - I've hardcoded it here to avoid using
create_configuration
, which @jalauzon-msft suggested as a possibility, but that means it won't automatically change if azure shifts it in future.The alternative approaches I can think of are:
create_configuration
, which would be responsive to changes from azure, but also potentially lead to issues in future since it is a private method.