Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write cache atomically using a tempfile in the same directory #1111

Merged
merged 4 commits into from
Nov 22, 2022
Merged

Write cache atomically using a tempfile in the same directory #1111

merged 4 commits into from
Nov 22, 2022

Conversation

jwodder
Copy link
Contributor

@jwodder jwodder commented Nov 11, 2022

Closes #1107.

@yarikoptic
Copy link
Contributor

FWIW: Although doesn't really resolve #1107 I think this PR is the right thing to do. WDYT @martindurant ?

@yarikoptic yarikoptic mentioned this pull request Nov 12, 2022
Closed
@jwodder jwodder mentioned this pull request Nov 21, 2022
Closed
@yarikoptic yarikoptic mentioned this pull request Nov 21, 2022
Merged
@jwodder jwodder marked this pull request as ready for review November 21, 2022 14:42
@yarikoptic
Copy link
Contributor

not sure why downstream testing errored out

Updating 'test_env' env from conda env update...
  /usr/share/miniconda/condabin/conda env update --name test_env --file ci/environment-downstream.yml
  Collecting package metadata (repodata.json): ...working... done
  Solving environment: ...working... ::endgroup::
Error: The process '/usr/share/miniconda/condabin/conda' failed with exit code null

and have no super-powers to restart, but I think this PR is ready for being reviewed/merged (attn @martindurant )

@martindurant
Copy link
Member

martindurant commented Nov 21, 2022 •
edited
Loading

Fixing CI in #1120 , probably needs a few iterations yet

done

@martindurant martindurant merged commit 057f533 into fsspec:master Nov 22, 2022
@yarikoptic yarikoptic mentioned this pull request Nov 29, 2022
Open
@jwodder jwodder deleted the gh-1107 branch October 27, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarikoptic yarikoptic yarikoptic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cached filesystem not concurrency-safe?
3 participants
@jwodder @yarikoptic @martindurant