Improve exception trace with RUF B904 #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martindurant
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
This was all auto-generated, correct?
I wonder if there any cases in which raise from ... causes bloat in the printout. That aside, I am in favour, es it at least provides the theoretical option for calling code to be more discriminating when handing our exceptions.
|
I manually added these to clarify. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the exception trace of all exceptions in filesystem spec by using the "from" keyword to specify a cause. I also enable a ruff rule B904 to require this cause in the future. I also enable RUF015 which ensure that we always access the first instance of iterable in constant time instead of using a linear time list or tuple constructor. I also had to change one of the exception catches to fix this in memory mapping.
Overall, this should prevent fsspec from swallowing the cause of exceptions nearly as much and return more info to the user when an exception occurs.