Core: Implement glob api #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xianyinxin
reviewed
Sep 9, 2024
| # Hyphens that create ranges shouldn't be escaped. | ||
| stuff = "-".join( | ||
| s.replace("\\", r"\\").replace("-", r"\-") for s in chunks | ||
| ) |
There was a problem hiding this comment.
could you please add some explanation about these code?
yanghua
commented
Sep 9, 2024
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """The module contains utility functions copied from fsspec package.""" |
There was a problem hiding this comment.
@xianyinxin I added a little description here, these code snippets are copied from fsspec's repo and utils.py. These codes do not exist in old fsspec versions(e.g. 2023.5.0).
xianyinxin
approved these changes
Sep 9, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary 📝
Write an overview about it.
Details
Describe more what you did on changes.
Bugfixes 🐛 (delete if dind't have any)
Checks