Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #1459

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Spelling #1459

merged 2 commits into from
Jan 2, 2025

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Dec 26, 2024

This PR corrects misspellings identified by the check-spelling action

The misspellings have been reported at https://github.com/jsoref/trippy/actions/runs/12505245426#summary-34888305694

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/trippy/actions/runs/12505245525#summary-34888305851

crates/trippy-core/src/strategy.rs Show resolved Hide resolved
crates/trippy-core/src/flows.rs Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
Copy link
Collaborator

@c-git c-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes look good to me. I didn't realize it also did grammar, that's a plus.

@jsoref
Copy link
Contributor Author

jsoref commented Dec 27, 2024

The grammar is just a series of rules I add as I run into people making mistakes, it isn't core to the engine, it just takes advantage of a feature.

@fujiapple852
Copy link
Owner

Thanks @jsoref !

If you can squash the 14x spelling fixes into a single docs: ... commit and rename link: step-by-step guide to manually configure the Windows Defender firewall rule as docs: it should be good to merge.

jsoref added 2 commits January 2, 2025 09:21
* configuration
* github
* greater
* id
* ip
* iterm
* long-standing
* macos
* pausemsecs
* same ttl
* the
* this
* ttl
* winget
* with

Signed-off-by: Josh Soref <[email protected]>
@fujiapple852 fujiapple852 enabled auto-merge (rebase) January 2, 2025 14:36
@fujiapple852 fujiapple852 merged commit 8bdb6a5 into fujiapple852:master Jan 2, 2025
22 checks passed
@jsoref jsoref deleted the spelling branch January 2, 2025 14:59
@c-git
Copy link
Collaborator

c-git commented Jan 2, 2025

Thanks @jsoref

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants