Added Front end with Routing Example #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holyjak
reviewed
Mar 15, 2022
| (defsc People [_this {:keys [people] :as _props}] | ||
| {:ident (fn [] [:component/id ::People]) | ||
| :query [{:people (comp/get-query Person)}] | ||
| :route-segment ["people"] |
There was a problem hiding this comment.
could be confusing having a route-segment when there is no router?
| :person/city "London" | ||
| :person/state "England"} | ||
| :append [:root :people])) | ||
| ``` |
holyjak
reviewed
Mar 15, 2022
| :toclevels: 2 | ||
| :description: Examples of Simple Use cases | ||
|
|
||
| Author: https://holyjak.cz/[Jakub Holý] & contributors |
There was a problem hiding this comment.
I have not written these :) Either add your name or just drop tje line.
|
Could you please add a description to the index.adoc explaining why it exists and thus what can readers gain from studying it? |
|
I'm thinking whether it wouldn't make more sense to make the code snippets into actual apps people can run, eg via Workspaces, eh in the https://github.com/fulcro-community/FulcroDemos repo... What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an example.