Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for do/raw-txn #22

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Conversation

holyjak
Copy link
Contributor

@holyjak holyjak commented Aug 19, 2023

Enable users of the save and delete middlewares to add to the generated transactions by adding a list of transaction data under the key do/raw-txn into Pathom env.

Also switched to the latest com.datomic/local and got rid of thus unnecessary dev-local-tu

(Updating to com.datomic/peer is blocked by datomock)

Testing

  1. Tests executed from CLI pass
  2. Manually tested for Cloud (via datomic-local) that both save and delete work without any raw-txn and do correctly apply an added raw-txn.

Not tested: Datomic Pro (other than what the automated tests do).

Enable users of the save and delete middlewares to add to the generated
transactions by adding a list of transaction data under the key do/raw-txn into Pathom env.

Also switched to the latest com.datomic/local and got rid of thus unnecessary `dev-local-tu`

(Updating to com.datomic/peer is blocked by datomock)
@holyjak holyjak force-pushed the add-option-raw-txn branch from 8373da6 to 623f24c Compare August 19, 2023 23:00
@awkay awkay merged commit ba55ebd into fulcrologic:main Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants