Add elementary support for minimal-pull under Pathom 3 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limitations: It only compares what the DB can offer against what the user _directly_ asked for. If a resolver needs extra input to compute a derived attribute, these will not be included.
|
I can't really merge this until one of us tests it against the demo or something |
|
You mean demo with Pathom 2, or with Pathom 3? I did test it on my app with Pathom 3. |
|
2 You said the change wasn't tested |
|
Ah, right, so you meant test in in Demo with P2. Will do! |
|
Thanks! |
|
Tested it now with rad-demo and it does what it should. With a debug log added: |
|
Where's |
|
Fire the minimal? I run on quiet that only requested the total
\---
Best Regards, Jakub Holý
https://holyjak.cz/
(Email signed with [ProtonMail][])
Sent from Proton Mail mobile
\-------- Original Message --------
On 17 Nov 2023, 19:10, Tony Kay < ***@***.***> wrote:
Where's `:invoice/date`?
—
Reply to this email directly, [view it on GitHub][], or [unsubscribe][].
You are receiving this because you authored the thread.![AAEYSPV6DH4EF2RYB4TFPP3YE6SA3A5CNFSM6AAAAAA6JVY2SCWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTMJNIRE.gif][]Message ID: ***@***.***>
[ProtonMail]: https://protonmail.com/
[view it on GitHub]: #27 (comment)
[unsubscribe]: https://github.com/notifications/unsubscribe-auth/AAEYSPTRUBL3JXISEU6OAE3YE6SA3AVCNFSM6AAAAAA6JVY2SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJWHA3TKMRYGI
[AAEYSPV6DH4EF2RYB4TFPP3YE6SA3A5CNFSM6AAAAAA6JVY2SCWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTMJNIRE.gif]: https://github.com/notifications/beacon/AAEYSPV6DH4EF2RYB4TFPP3YE6SA3A5CNFSM6AAAAAA6JVY2SCWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTMJNIRE.gif
|
holyjak
added a commit
to holyjak/fulcro-rad-datomic
that referenced
this pull request
Jan 14, 2024
Limitations: It only compares what the DB can offer against what the user _directly_ asked for. If a resolver needs extra input to compute a derived attribute, these will not be included. Essentially the same as fulcrologic#27 but preserves `prune-query` with the original signature so we do not break any client code that can be relying on it.
awkay
pushed a commit
that referenced
this pull request
Jan 15, 2024
Limitations: It only compares what the DB can offer against what the user _directly_ asked for. If a resolver needs extra input to compute a derived attribute, these will not be included. Essentially the same as #27 but preserves `prune-query` with the original signature so we do not break any client code that can be relying on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limitations: It only compares what the DB can offer against what the user directly asked for. If a resolver needs extra input to compute a derived attribute, these will not be included.
Beware: Not tested under P2.