Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a bug when processing data without socre columns. #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed a bug when processing data without socre columns. #2

wants to merge 2 commits into from

Conversation

miyamamoto
Copy link
Contributor

No description provided.

@fullflu
Copy link
Owner

fullflu commented Nov 24, 2016

Hi @miyamamoto thank you for submitting this pull request.

I understand a bug when processing data without score columns, but I guess there are still some bugs of the scripts.

  • First, line 70 of listnet.py
self.T = len(self.X)

may be

self.test_T = len(self.test_X)
  • Second, line 4 of getsampledata.sh
unrar MQ2008.rar

may be

unrar x MQ2008.rar

I'd like to hear your opinion.

@miyamamoto
Copy link
Contributor Author

miyamamoto commented Dec 9, 2016 •
edited
Loading

Thank you very much.
Certainly, I think that the above correction is necessary. I will correct it and send a pull request again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miyamamoto @fullflu