Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix answer checker #21

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix answer checker #21

merged 1 commit into from
Sep 18, 2023

Conversation

royderegt
Copy link
Contributor

Hi,
I ran into the following while working with the notebook matrix_matrix.ipynb:


a) O(N²) communication and O(N³) computation
b) O(N²) communication and O(N³/P) computation
c) O(N²) communication and O(N²) computation
d) O(N²/P) communication and O(N³/P) computation

Where D is marked as the correct answer. As far as I'm concerned, B is the correct answer as the communication complexity is in O(N²).

Both the slides and the table below the question say that the communication overhead is N² + 2N²/P, which makes the dominant factor.

@fverdugo
Copy link
Owner

Hi @royderegt,

Thanks for noticing this.

Yes, communication cost is N^2 for algorithm 3 in the matrix-matrix product notebook.

@fverdugo fverdugo merged commit 441a15f into fverdugo:main Sep 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants