Re-enable tags management based on the taxonomy instead of IndexedDB (fixes #90, fixes #98). r=gmarty #150
Conversation
| @@ -0,0 +1 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" height="30" width="30" version="1.1"><g transform="matrix(.019697 0 0 -.019697 .079568 27.813)"><path fill="#fff" d="m448 1088q0 53-37.5 90.5t-90.5 37.5-90.5-37.5-37.5-90.5 37.5-90.5 90.5-37.5 90.5 37.5 37.5 90.5zm1067-576q0-53-37-90l-491-492q-39-37-91-37-53 0-90 37l-715 716q-38 37-64.5 101t-26.5 117v416q0 52 38 90t90 38h416q53 0 117-26.5t102-64.5l715-714q37-39 37-91z"/></g></svg> | |||
There was a problem hiding this comment.
This file can be minified further. I usually only use a viewBox attribute in lieu of height and width. The version attribute can be removed to.
It's better if the transform tag is removed and its effect merged into the path values.
I can do that operation for you if you want.
There was a problem hiding this comment.
Ah, you can teach me :) How would you merge transform directly to the path (without manually doing matrix math)?
There was a problem hiding this comment.
Ah nevermind, I've just noticed Path -> Simplify in Inkscape that did the job :)
There was a problem hiding this comment.
Yes, Inkscape is your friend! I don't usually blindy trust svgo. In simple cases like this one, I make sure that there is only one path defined and no useless tags.
|
This approach works for me! Feel free to ping me for a proper r? when you're ready. |
| @@ -193,6 +193,7 @@ export default class Recipes { | |||
| id: getter.id, | |||
| kind: getter.kind, | |||
| name: name || getter.adapter, | |||
| tags: getter.tags, | |||
There was a problem hiding this comment.
If this tag idea sticks, later we can also use tags inside recipe name/label/text.
|
r? @gmarty It should be ready for review, I'm still trying to figure out why login tests started to fail.... but this should not affect PR anyway. |
Okay, found and fixed - in |
| @@ -0,0 +1 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 30 30"><path fill="#000" d="M 6.6191408,1.4609377 C 4.8997398,3.1803387 3.1803387,4.8997398 1.4609377,6.6191408 4.2545575,9.4127605 7.0481774,12.20638 9.8417972,15 7.0481774,17.79362 4.2545575,20.587239 1.4609377,23.380859 3.1803387,25.10026 4.8997398,26.819661 6.6191408,28.539062 9.4127605,25.745442 12.20638,22.951823 15,20.158203 c 2.79362,2.79362 5.587239,5.587239 8.380859,8.380859 1.719401,-1.719401 3.438802,-3.438802 5.158203,-5.158203 C 25.745442,20.587239 22.951823,17.79362 20.158203,15 22.951823,12.20638 25.745442,9.4127605 28.539062,6.6191408 26.819661,4.8997398 25.10026,3.1803387 23.380859,1.4609377 20.587239,4.2545575 17.79362,7.0481774 15,9.8417972 12.20638,7.0481774 9.4127605,4.2545575 6.6191408,1.4609377 Z" /></svg> | |||
There was a problem hiding this comment.
Have you used svgo on these icons? It looks like they can be compressed even further.
There was a problem hiding this comment.
Nope :) Didn't know about svgo btw, thanks!
There was a problem hiding this comment.
Wow, 0.774 KiB - 73.1% = 0.208 KiB \0/
|
It looks good to me. I left a few questions/nits. |
| this.state = { | ||
| name: this.service.name, | ||
| }; | ||
|
|
There was a problem hiding this comment.
nit: moving this block kind of pollutes the git diff.
No description provided.