Skip to content

Commit

Permalink
fix: remove weekend spend key from expenses (#3154)
Browse files Browse the repository at this point in the history
  • Loading branch information
bistaastha committed Jul 31, 2024
1 parent 26cc972 commit 05c43ef
Show file tree
Hide file tree
Showing 35 changed files with 192 additions and 193 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
export enum ExpenseTransactionStatus {
PENDING = 'PENDING',
POSTED = 'POSTED',
}
4 changes: 2 additions & 2 deletions src/app/core/mock-data/cc-transaction.data.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import deepFreeze from 'deep-freeze-strict';

import { corporateCardTransaction } from '../models/platform/v1/cc-transaction.model';
import { TransactionStatus } from '../models/platform/v1/expense.model';
import { ExpenseTransactionStatus } from '../enums/platform/v1/expense-transaction-status.enum';

export const ccTransactionData: corporateCardTransaction = deepFreeze({
amount: 260.37,
Expand Down Expand Up @@ -97,7 +97,7 @@ export const ccTransactionData: corporateCardTransaction = deepFreeze({
post_date: null,
spent_at: '2018-07-04T00:00:00+00:00',
statement_id: 'stmt2K9aLunGU4',
transaction_status: TransactionStatus.PENDING,
transaction_status: ExpenseTransactionStatus.PENDING,
updated_at: '2024-02-13T03:10:49.432028+00:00',
user: {
email: '[email protected]',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import deepFreeze from 'deep-freeze-strict';

import { CorporateCardTransactionRes } from '../models/platform/v1/corporate-card-transaction-res.model';
import { TransactionStatus } from '../models/platform/v1/expense.model';
import { ExpenseTransactionStatus } from '../enums/platform/v1/expense-transaction-status.enum';

export const ccTransactionResponseData: CorporateCardTransactionRes = deepFreeze({
data: [
Expand Down Expand Up @@ -212,7 +212,7 @@ export const unmatchCCCExpenseResponseData: CorporateCardTransactionRes = deepFr
post_date: null,
spent_at: '2018-07-04T00:00:00+00:00',
statement_id: 'stmt2K9aLunGU4',
transaction_status: TransactionStatus.PENDING,
transaction_status: ExpenseTransactionStatus.PENDING,
updated_at: '2024-02-13T03:10:49.432028+00:00',
user: {
email: '[email protected]',
Expand Down Expand Up @@ -267,7 +267,7 @@ export const matchCCCExpenseResponseData: CorporateCardTransactionRes = deepFree
post_date: null,
spent_at: '2018-07-04T00:00:00+00:00',
statement_id: 'stmt2K9aLunGU4',
transaction_status: TransactionStatus.PENDING,
transaction_status: ExpenseTransactionStatus.PENDING,
updated_at: '2024-02-13T03:10:48.454767+00:00',
user: {
email: '[email protected]',
Expand Down Expand Up @@ -367,7 +367,7 @@ export const ccTransactionResponseData3: CorporateCardTransactionRes = deepFreez
id: 'usvMoPfCC9Xw',
},
user_id: 'usvMoPfCC9Xw',
transaction_status: TransactionStatus.POSTED,
transaction_status: ExpenseTransactionStatus.POSTED,
},
{
amount: 205.21,
Expand Down Expand Up @@ -455,7 +455,7 @@ export const ccTransactionResponseData3: CorporateCardTransactionRes = deepFreez
id: 'usvMoPfCC9Xw',
},
user_id: 'usvMoPfCC9Xw',
transaction_status: TransactionStatus.PENDING,
transaction_status: ExpenseTransactionStatus.PENDING,
},
],
});
6 changes: 3 additions & 3 deletions src/app/core/mock-data/matchedCCTransaction.data.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import deepFreeze from 'deep-freeze-strict';

import { MatchedCCCTransaction } from '../models/matchedCCCTransaction.model';
import { TransactionStatus } from '../models/platform/v1/expense.model';
import { ExpenseTransactionStatus } from '../enums/platform/v1/expense-transaction-status.enum';

export const matchedCCTransactionData: Partial<MatchedCCCTransaction> = deepFreeze({
id: 'btxnSte7sVQCM8',
Expand All @@ -15,7 +15,7 @@ export const matchedCCTransactionData: Partial<MatchedCCCTransaction> = deepFree
corporate_credit_card_account_number: '7620',
orig_amount: null,
orig_currency: null,
status: TransactionStatus.PENDING,
status: ExpenseTransactionStatus.PENDING,
displayObject: 'Jul 3, 2018 - test description260.37',
});

Expand All @@ -31,7 +31,7 @@ export const matchedCCTransactionData2: Partial<MatchedCCCTransaction> = deepFre
corporate_credit_card_account_number: '9891',
orig_amount: null,
orig_currency: null,
status: TransactionStatus.PENDING,
status: ExpenseTransactionStatus.PENDING,
displayObject: 'Jun 6, 2018 - test description205.21',
});

Expand Down
26 changes: 26 additions & 0 deletions src/app/core/mock-data/platform/v1/expense-employee.model.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import { NameValuePair } from 'src/app/core/models/name-value-pair.model';
import { Department } from 'src/app/core/models/platform/v1/department.model';
import { Level } from 'src/app/core/models/platform/v1/level.model';
import { User } from 'src/app/core/models/platform/v1/user.model';

export interface ExpenseEmployee {
business_unit: string;
code: string;
custom_fields: NameValuePair[];
department: Pick<Department, 'id' | 'code' | 'display_name' | 'sub_department' | 'name'>;
department_id: string;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
flattened_custom_field: Record<string, any>;
has_accepted_invite: boolean;
id: string;
is_enabled: boolean;
joined_at?: Date;
mobile?: string;
level: Pick<Level, 'id' | 'name' | 'band'>;
location: string;
org_id: string;
org_name: string;
title: string;
user: User;
user_id: string;
}
21 changes: 5 additions & 16 deletions src/app/core/mock-data/platform/v1/expense.data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@ import { MileageUnitEnum } from 'src/app/core/models/platform/platform-mileage-r
import { ReportState } from 'src/app/core/models/platform/v1/report.model';
import { ApprovalState } from 'src/app/core/models/platform/report-approvals.model';
import { AccountType } from 'src/app/core/models/platform/v1/account.model';
import { Expense, TransactionStatus } from 'src/app/core/models/platform/v1/expense.model';
import { Expense } from 'src/app/core/models/platform/v1/expense.model';
import { FileType } from 'src/app/core/models/platform/v1/file.model';
import { CustomFieldTypes } from 'src/app/core/enums/platform/v1/custom-fields-type.enum';
import { CommuteDeduction } from 'src/app/core/enums/commute-deduction.enum';
import { ExpenseTransactionStatus } from 'src/app/core/enums/platform/v1/expense-transaction-status.enum';

export const expenseData: Expense = deepFreeze({
accounting_export_summary: {},
Expand Down Expand Up @@ -119,7 +120,6 @@ export const expenseData: Expense = deepFreeze({
is_reimbursable: false,
is_split: false,
is_verified: true,
is_weekend_spend: false,
last_exported_at: null,
last_settled_at: null,
last_verified_at: new Date('2023-10-31T18:15:25.494224+00:00'),
Expand All @@ -143,7 +143,7 @@ export const expenseData: Expense = deepFreeze({
merchant: 'Merchant1',
posted_at: null,
spent_at: new Date('2023-10-15T00:00:00+00:00'),
status: TransactionStatus?.PENDING,
status: ExpenseTransactionStatus?.PENDING,
},
],
merchant: null,
Expand Down Expand Up @@ -532,7 +532,6 @@ export const mileageExpense: Expense = deepFreeze({
is_reimbursable: true,
is_split: false,
is_verified: false,
is_weekend_spend: false,
last_exported_at: null,
last_settled_at: null,
last_verified_at: null,
Expand Down Expand Up @@ -889,7 +888,6 @@ export const perDiemExpense: Expense = deepFreeze({
is_reimbursable: true,
is_split: false,
is_verified: false,
is_weekend_spend: false,
last_exported_at: null,
last_settled_at: null,
last_verified_at: null,
Expand Down Expand Up @@ -1022,6 +1020,7 @@ export const criticalPolicyViolatedExpense: Expense = deepFreeze({
policy_amount: 0.00009,
});

// eslint-disable-next-line custom-rules/prefer-semantic-extension-name
type Category = Pick<PlatformCategory, 'code' | 'id' | 'display_name' | 'name' | 'sub_category' | 'system_category'>;

const mileageCategory: Category = deepFreeze({
Expand Down Expand Up @@ -1292,7 +1291,6 @@ export const apiExpenses1: Expense[] = deepFreeze([
is_reimbursable: true,
is_split: true,
is_verified: false,
is_weekend_spend: false,
last_exported_at: null,
last_settled_at: null,
last_verified_at: null,
Expand Down Expand Up @@ -1646,7 +1644,6 @@ export const apiExpenses1: Expense[] = deepFreeze([
is_reimbursable: true,
is_split: true,
is_verified: false,
is_weekend_spend: false,
last_exported_at: null,
last_settled_at: null,
last_verified_at: null,
Expand Down Expand Up @@ -1861,7 +1858,6 @@ export const splitExpensesData: Expense[] = deepFreeze([
is_reimbursable: false,
is_split: true,
is_verified: false,
is_weekend_spend: false,
last_exported_at: null,
last_settled_at: null,
last_verified_at: null,
Expand Down Expand Up @@ -2006,7 +2002,6 @@ export const splitExpensesData: Expense[] = deepFreeze([
is_reimbursable: false,
is_split: true,
is_verified: false,
is_weekend_spend: false,
last_exported_at: null,
last_settled_at: null,
last_verified_at: null,
Expand Down Expand Up @@ -2156,7 +2151,6 @@ export const apiExpenses3: Expense[] = deepFreeze([
is_reimbursable: false,
is_split: true,
is_verified: false,
is_weekend_spend: false,
last_exported_at: null,
last_settled_at: null,
last_verified_at: null,
Expand Down Expand Up @@ -2301,7 +2295,6 @@ export const apiExpenses3: Expense[] = deepFreeze([
is_reimbursable: false,
is_split: true,
is_verified: false,
is_weekend_spend: false,
last_exported_at: null,
last_settled_at: null,
last_verified_at: null,
Expand Down Expand Up @@ -2461,7 +2454,6 @@ export const platformExpenseData: Expense = deepFreeze({
is_reimbursable: true,
is_split: false,
is_verified: false,
is_weekend_spend: false,
last_exported_at: null,
last_settled_at: null,
last_verified_at: null,
Expand Down Expand Up @@ -2640,7 +2632,6 @@ export const platformExpenseDataWithSubCategory: Expense = deepFreeze({
is_reimbursable: true,
is_split: false,
is_verified: false,
is_weekend_spend: false,
last_exported_at: null,
last_settled_at: null,
last_verified_at: null,
Expand Down Expand Up @@ -2881,7 +2872,6 @@ export const platformExpenseWithExtractedData: Expense = deepFreeze({
is_reimbursable: true,
is_split: false,
is_verified: false,
is_weekend_spend: false,
last_exported_at: null,
last_settled_at: null,
last_verified_at: null,
Expand Down Expand Up @@ -3044,7 +3034,6 @@ export const platformExpenseWithMatchCCC: Expense = deepFreeze({
is_reimbursable: false,
is_split: false,
is_verified: null,
is_weekend_spend: false,
last_exported_at: null,
last_settled_at: null,
last_verified_at: null,
Expand All @@ -3068,7 +3057,7 @@ export const platformExpenseWithMatchCCC: Expense = deepFreeze({
merchant: 'test description',
posted_at: null,
spent_at: new Date('2018-07-03T18:30:00.000Z'),
status: TransactionStatus.PENDING,
status: ExpenseTransactionStatus.PENDING,
},
],
merchant: 'test description',
Expand Down
5 changes: 2 additions & 3 deletions src/app/core/mock-data/transaction.data.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import deepFreeze from 'deep-freeze-strict';

import { TransactionStatus } from '../models/platform/v1/expense.model';
import { Transaction } from '../models/v1/transaction.model';
import { optionsData15, optionsData33 } from './merge-expenses-options-data.data';
import { expectedTxnCustomProperties, txnCustomPropertiesData } from './txn-custom-properties.data';
import { ExpenseTransactionStatus } from '../enums/platform/v1/expense-transaction-status.enum';

export const txnList: Transaction[] = deepFreeze([
{
Expand Down Expand Up @@ -4130,7 +4129,7 @@ export const editUnflattenedTransactionWithMatchCCCPlatform: Partial<Transaction
corporate_credit_card_account_number: '7620',
orig_amount: null,
orig_currency: null,
status: TransactionStatus.PENDING,
status: ExpenseTransactionStatus.PENDING,
displayObject: 'Jul 4, 2018 - test description260.37',
},
],
Expand Down
7 changes: 3 additions & 4 deletions src/app/core/mock-data/transformed-expense.data.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import deepFreeze from 'deep-freeze-strict';

import { TransactionStatus } from '../models/platform/v1/expense.model';
import { UnflattenedTransaction } from '../models/unflattened-transaction.model';
import { ExpenseTransactionStatus } from '../enums/platform/v1/expense-transaction-status.enum';

export const transformedExpenseData: Partial<UnflattenedTransaction> = deepFreeze({
tx: {
Expand Down Expand Up @@ -390,7 +389,7 @@ export const transformedExpenseWithMatchCCCData: Partial<UnflattenedTransaction>
corporate_credit_card_account_number: '7620',
orig_amount: null,
orig_currency: null,
status: TransactionStatus.PENDING,
status: ExpenseTransactionStatus.PENDING,
},
],
source_account_id: 'acc7F6bwRa52p',
Expand Down Expand Up @@ -435,7 +434,7 @@ export const transformedExpenseWithMatchCCCData3: Partial<UnflattenedTransaction
corporate_credit_card_account_number: '9891',
orig_amount: null,
orig_currency: null,
status: TransactionStatus.PENDING,
status: ExpenseTransactionStatus.PENDING,
displayObject: 'Jun 6, 2018 - test description205.21',
},
],
Expand Down
4 changes: 2 additions & 2 deletions src/app/core/models/matchedCCCTransaction.model.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { TransactionStatus } from './platform/v1/expense.model';
import { ExpenseTransactionStatus } from '../enums/platform/v1/expense-transaction-status.enum';

export interface MatchedCCCTransaction {
amount: number;
Expand All @@ -18,6 +18,6 @@ export interface MatchedCCCTransaction {
vendor: string;
corporate_credit_card_account_number?: string;
displayObject?: string;
status?: TransactionStatus;
status?: ExpenseTransactionStatus;
corporate_card_nickname?: string;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
export interface AccountingExportSummary {
state: string;
error_type: string;
url: string;
tpa_id: string;
}
4 changes: 2 additions & 2 deletions src/app/core/models/platform/v1/cc-transaction.model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { AssignorUser } from './assignor-user.model';
import { CorporateCard } from './corporate-card.model';
import { CCMatchedExpense } from './cc-matched-expense.model';
import { CCTransactionMetadata } from './cc-transaction-metadata';
import { TransactionStatus } from './expense.model';
import { ExpenseTransactionStatus } from 'src/app/core/enums/platform/v1/expense-transaction-status.enum';

export interface corporateCardTransaction {
id: string;
Expand Down Expand Up @@ -46,5 +46,5 @@ export interface corporateCardTransaction {
matched_expenses: CCMatchedExpense[];
last_user_matched_at: Date;
metadata?: CCTransactionMetadata;
transaction_status?: TransactionStatus;
transaction_status?: ExpenseTransactionStatus;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
export interface ExpenseMissingMandatoryFields {
expense_field_ids: number[];
amount: boolean;
currency: boolean;
receipt: boolean;
}
17 changes: 17 additions & 0 deletions src/app/core/models/platform/v1/expense-report.model.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { ReportApprovals } from '../report-approvals.model';
import { ReportState } from './report.model';

export interface ExpenseReport {
amount: number;
approvals: ReportApprovals[];
id: string;
last_approved_at: Date;
last_paid_at: Date;
last_submitted_at: Date;
seq_num: string;
state: ReportState;
last_verified_at: Date;
reimbursement_id: string;
reimbursement_seq_num: string;
title: string;
}
11 changes: 11 additions & 0 deletions src/app/core/models/platform/v1/expense-rule-data.model.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { NameValuePair } from '../../name-value-pair.model';

export interface ExpenseRuleData {
merchant: string;
is_billable: boolean;
purpose: string;
category_id: number;
project_id: number;
cost_center_id: number;
custom_fields: NameValuePair[];
}
Loading

0 comments on commit 05c43ef

Please sign in to comment.