Skip to content

Commit

Permalink
fix: fix reference for system_category field to make sub categories v…
Browse files Browse the repository at this point in the history
…isible in Mileage Form (#3215)
  • Loading branch information
bistaastha committed Oct 1, 2024
1 parent 83c9faa commit f6bc177
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/app/core/mock-data/org-category.data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1103,7 +1103,7 @@ export const mileageCategories2: OrgCategory[] = deepFreeze([
created_at: new Date('2021-05-18T11:40:38.576Z'),
displayName: 'mileage',
enabled: true,
fyle_category: 'Food',
fyle_category: 'Mileage',
id: 141295,
name: 'mileage',
org_id: 'orrjqbDbeP9p',
Expand Down
4 changes: 2 additions & 2 deletions src/app/fyle/add-edit-mileage/add-edit-mileage-2.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ export function TestCases2(getTestBed) {
component.getMileageCategories().subscribe((res) => {
expect(res).toEqual({
defaultMileageCategory: mileageCategories2[0],
mileageCategories: [mileageCategories2[1]],
mileageCategories: [mileageCategories2[0], mileageCategories2[1]],
});
expect(categoriesService.getAll).toHaveBeenCalledTimes(1);
done();
Expand All @@ -262,7 +262,7 @@ export function TestCases2(getTestBed) {
categoriesService.getAll.and.returnValue(of(mileageCategories2));

component.getSubCategories().subscribe((res) => {
expect(res).toEqual([mileageCategories2[0]]);
expect(res).toEqual([mileageCategories2[0], mileageCategories2[1]]);
expect(categoriesService.getAll).toHaveBeenCalledTimes(1);
done();
});
Expand Down
2 changes: 1 addition & 1 deletion src/app/fyle/add-edit-mileage/add-edit-mileage.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,7 @@ export class AddEditMileagePage implements OnInit {
const parentCategoryName = 'mileage';
return categories.filter(
(orgCategory) =>
parentCategoryName.toLowerCase() === orgCategory.name?.toLowerCase() &&
parentCategoryName.toLowerCase() === orgCategory.fyle_category?.toLowerCase() &&
parentCategoryName.toLowerCase() !== orgCategory.sub_category?.toLowerCase()
);
}),
Expand Down
2 changes: 1 addition & 1 deletion src/app/fyle/add-edit-per-diem/add-edit-per-diem.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ export class AddEditPerDiemPage implements OnInit {
const parentCategoryName = 'per diem';
return categories.filter(
(orgCategory) =>
parentCategoryName.toLowerCase() === orgCategory.name?.toLowerCase() &&
parentCategoryName.toLowerCase() === orgCategory.fyle_category?.toLowerCase() &&
parentCategoryName.toLowerCase() !== orgCategory.sub_category?.toLowerCase()
);
}),
Expand Down

0 comments on commit f6bc177

Please sign in to comment.