fix: name changes for Updated on -> Updated date (#3486)

* fix: name changes for Updated on -> Updated date * linting fix --------- Co-authored-by: Amit Pile <[email protected]>
fylein · Feb 6, 2025 · ff2aacf · ff2aacf
1 parent 14730c8
commit ff2aacf
Show file tree

Hide file tree

Showing 7 changed files with 22 additions and 21 deletions.
diff --git a/src/app/core/mock-data/filter-pills.data.ts b/src/app/core/mock-data/filter-pills.data.ts
@@ -25,7 +25,7 @@ export const allFilterPills: FilterPill[] = deepFreeze([
     value: '2023-02-20 to 2023-02-22',
   },
   {
-    label: 'Updated On',
+    label: 'Updated date',
     type: 'date',
     value: '2023-02-22 to 2023-02-24',
   },

diff --git a/src/app/core/mock-data/selected-filters.data.ts b/src/app/core/mock-data/selected-filters.data.ts
@@ -12,7 +12,7 @@ export const selectedFilters1: SelectedFilters<string>[] = deepFreeze([
     },
   },
   {
-    name: 'Updated On',
+    name: 'Updated date',
     value: 'custom',
     associatedData: {
       startDate: new Date('2023-02-22T00:00:00.000Z'),
@@ -35,7 +35,7 @@ export const selectedFilters1: SelectedFilters<string>[] = deepFreeze([
 
 export const selectedFilters2: SelectedFilters<string>[] = deepFreeze([
   {
-    name: 'Updated On',
+    name: 'Updated date',
     value: 'custom',
     associatedData: {
       startDate: new Date('2023-02-22T00:00:00.000Z'),

diff --git a/src/app/core/services/personal-cards.service.spec.ts b/src/app/core/services/personal-cards.service.spec.ts
@@ -435,7 +435,7 @@ describe('PersonalCardsService', () => {
       personalCardsService.generateUpdatedOnCustomDatePill(filters, filterPills);
       expect(filterPills).toEqual([
         {
-          label: 'Updated On',
+          label: 'Updated date',
           type: 'date',
           value: '2023-02-21 to 2023-02-23',
         },
@@ -456,7 +456,7 @@ describe('PersonalCardsService', () => {
       personalCardsService.generateUpdatedOnCustomDatePill(filters, filterPills);
       expect(filterPills).toEqual([
         {
-          label: 'Updated On',
+          label: 'Updated date',
           type: 'date',
           value: '>= 2023-02-21',
         },
@@ -477,7 +477,7 @@ describe('PersonalCardsService', () => {
       personalCardsService.generateUpdatedOnCustomDatePill(filters, filterPills);
       expect(filterPills).toEqual([
         {
-          label: 'Updated On',
+          label: 'Updated date',
           type: 'date',
           value: '<= 2023-02-23',
         },
@@ -601,7 +601,7 @@ describe('PersonalCardsService', () => {
       personalCardsService.generateDateFilterPills('updatedOn', filters, filterPills);
       expect(filterPills).toEqual([
         {
-          label: 'Updated On',
+          label: 'Updated date',
           type: 'date',
           value: '>= 2023-02-21',
         },

diff --git a/src/app/core/services/personal-cards.service.ts b/src/app/core/services/personal-cards.service.ts
@@ -256,7 +256,7 @@ export class PersonalCardsService {
       }
     }
 
-    const updatedOnDateFilter = selectedFilters.find((filter) => filter.name === 'Updated On');
+    const updatedOnDateFilter = selectedFilters.find((filter) => filter.name === 'Updated date');
     if (updatedOnDateFilter) {
       generatedFilters.updatedOn = { name: updatedOnDateFilter.value };
       if (updatedOnDateFilter.associatedData) {
@@ -280,7 +280,7 @@ export class PersonalCardsService {
     if (filter?.updatedOn) {
       const dateFilter = filter;
       generatedFilters.push({
-        name: 'Updated On',
+        name: 'Updated date',
         value: dateFilter.updatedOn.name,
         associatedData: {
           startDate: dateFilter.updatedOn.customDateStart,
@@ -406,19 +406,19 @@ export class PersonalCardsService {
 
     if (startDate && endDate) {
       filterPills.push({
-        label: 'Updated On',
+        label: 'Updated date',
         type: 'date',
         value: `${startDate} to ${endDate}`,
       });
     } else if (startDate) {
       filterPills.push({
-        label: 'Updated On',
+        label: 'Updated date',
         type: 'date',
         value: `>= ${startDate}`,
       });
     } else if (endDate) {
       filterPills.push({
-        label: 'Updated On',
+        label: 'Updated date',
         type: 'date',
         value: `<= ${endDate}`,
       });

diff --git a/src/app/fyle/personal-cards/personal-cards.page.spec.ts b/src/app/fyle/personal-cards/personal-cards.page.spec.ts
@@ -647,7 +647,7 @@ describe('PersonalCardsPage', () => {
           updatedOn: {},
         };
 
-        component.onFilterClose('Updated On');
+        component.onFilterClose('Updated date');
         expect(component.addNewFiltersToParams).toHaveBeenCalledTimes(1);
         expect(personalCardsService.generateFilterPills).toHaveBeenCalledTimes(1);
       });

diff --git a/src/app/fyle/personal-cards/personal-cards.page.ts b/src/app/fyle/personal-cards/personal-cards.page.ts
@@ -611,7 +611,7 @@ export class PersonalCardsPage implements OnInit, AfterViewInit {
             ],
           } as FilterOptions<DateFilters>,
           {
-            name: 'Updated On',
+            name: 'Updated date',
             optionType: FilterOptionType.date,
             options: [
               {
@@ -720,7 +720,7 @@ export class PersonalCardsPage implements OnInit, AfterViewInit {
       delete this.filters.createdOn;
     }
 
-    if (filterLabel === 'Updated On') {
+    if (filterLabel === 'Updated date') {
       delete this.filters.updatedOn;
     }
 

diff --git a/src/app/shared/components/fy-filters/fy-filters.component.spec.ts b/src/app/shared/components/fy-filters/fy-filters.component.spec.ts
@@ -80,7 +80,7 @@ describe('FyFiltersComponent', () => {
     fixture.detectChanges();
     expect(component.currentFilterValueMap).toEqual({
       'Created On': 'custom',
-      'Updated On': 'custom',
+      'Updated date': 'custom',
       'Transactions Type': 'Debit',
       Type: 'custom',
       'Receipts Attached': 'custom',
@@ -275,8 +275,8 @@ describe('FyFiltersComponent', () => {
 
     component.ngOnInit();
     fixture.detectChanges();
-    expect(component.startDate).toEqual(undefined);
-    expect(component.endDate).toEqual(undefined);
+    expect(component.startDate).toBeUndefined();
+    expect(component.endDate).toBeUndefined();
   });
 
   it('should set filterOptions options to optionsNewFlowCCCOnly', () => {
@@ -532,20 +532,21 @@ describe('FyFiltersComponent', () => {
     fixture.detectChanges();
     expect(component.currentFilterValueMap).toEqual({
       'Created On': 'custom',
-      'Updated On': 'custom',
+      'Updated date': 'custom',
       'Transactions Type': 'Debit',
       Type: 'custom',
       'Receipts Attached': 'custom',
     });
     expect(component.customDateMap).toEqual({});
-    expect(component.startDate).toEqual(undefined);
-    expect(component.endDate).toEqual(undefined);
+    expect(component.startDate).toBeUndefined();
+    expect(component.endDate).toBeUndefined();
     component.clearAll();
     expect(component.currentFilterValueMap).toEqual({});
     expect(component.customDateMap).toEqual({});
     expect(component.startDate).toBeNull();
     expect(component.endDate).toBeNull();
   });
+
   it('onDateChange(): should update startDate and endDate', () => {
     component.simplifyReportsSettings$ = of({ enabled: false });
     component.selectedFilterValues = selectedFilters1;