Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace atty by std::io::IsTerminal #2332

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Conversation

atezet
Copy link
Contributor

@atezet atezet commented Sep 30, 2024

Changes

atty is now unmaintained RUSTSEC-2024-0375. Replaced the only occurrence with std::io::IsTerminal.

Checklist

  • An issue to be fixed by this PR is listed above.
  • [-] New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • [-] If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Sep 30, 2024

LGTM and thanks!

To make CI happy, I guess you can either (1) revert the changes to pubspec.lock (2) or use the same Flutter version as CI's. Feel free to ping me after CI is green to merge it :)

@fzyzcjy fzyzcjy merged commit 7e32d04 into fzyzcjy:master Oct 1, 2024
135 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants