Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade serde yaml #2333

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Upgrade serde yaml #2333

merged 2 commits into from
Oct 1, 2024

Conversation

atezet
Copy link
Contributor

@atezet atezet commented Sep 30, 2024

Changes

Upgrade serde_yaml to the newest released version (0.9). serde_yaml 0.8 depends on the unmaintained yaml-rust RUSTSEC-2024-0320, and an upgrade didn't seem to break anything. Point of discussion is that serde_yaml is now archived/deprecated entirely and will probably be marked as unmaintained in the near future as well rustsec/advisory-db#1925.

Checklist

  • An issue to be fixed by this PR is listed above.
  • [-] New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • [-] If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Sep 30, 2024

Point of discussion is that serde_yaml is now archived/deprecated entirely and will probably be marked as unmaintained in the near future as well rustsec/advisory-db#1925.

Yes I think so...

Copy link
Owner

@fzyzcjy fzyzcjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just ping me when CI is green!

@atezet
Copy link
Contributor Author

atezet commented Sep 30, 2024

@fzyzcjy this one's green!

@fzyzcjy fzyzcjy merged commit 5ee14de into fzyzcjy:master Oct 1, 2024
134 of 135 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants