feat!: add base and aac-2017 models from 1.0.0-ballot.2024-11.2 release #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korikuzma
commented
Jan 23, 2025
10 tasks
quinnwai
reviewed
Jan 24, 2025
| locusAlleleCount=34086, | ||
| cohort=StudyGroup(id="ALL", label="Overall"), | ||
| ) | ||
| assert caf.focusAllele.root == "allele.json#/1" |
There was a problem hiding this comment.
Just clarifying, so I should always use .root for accessing the string for an iriReference? I'm putting in a VRS Allele ID in there, not sure if I'm using it right.
There was a problem hiding this comment.
Just clarifying, so I should always use .root for accessing the string for an iriReference?
Yes
There was a problem hiding this comment.
Can you give the example you're using?
There was a problem hiding this comment.
Yeah it would look something like this (model dumped, excluding None):
{
"type": "CohortAlleleFrequencyStudyResult",
"sourceDataSet": {
"id": "../tests/fixtures/1kGP.chr1.1000.vrs.vcf.gz",
"type": "DataSet",
"description": "Created 2025-01-24 14:34:54.383668"
},
"focusAllele": "ga4gh:VA.1WRXw4TC5DYsjC2QLyKux9C0xETLN3Yt",
"focusAlleleCount": 248,
"locusAlleleCount": 1184,
"focusAlleleFrequency": 0.20945945945945946,
"cohort": {
"id": "USA",
"type": "StudyGroup",
"label": "USA"
},
"ancillaryResults": {
"homozygotes": 1,
"hemizygotes": 246,
"phenotypes": [
"USA"
]
}
}
There was a problem hiding this comment.
ok! In that case, it could be helpful to users to have on the iriReference docs that the string value is nested in .root!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #11