Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cicd: add precommit checks to GitHub actions #621

Merged
merged 7 commits into from
Jan 2, 2025

Conversation

jsstevenson
Copy link
Contributor

@jsstevenson jsstevenson commented Dec 20, 2024

(low priority)

I noticed in #622 that the latest commit on this branch seemed to be in violation of some precommit hooks, so small changes to the schema source were introducing downstream changes to a bunch of unrelated def/json files.

This PR

  1. catches up on those changes and
  2. adds a precommit check to github actions to help contributors remember to run appropriate make commands/formatting hooks in their editors (or to install precommit themselves).

Higher order question as pointed out by @korikuzma in #622 : are all of these autogenerated changes correct (though it's also plausible that I'm messing it up somehow)?

@jsstevenson jsstevenson changed the title hm... cicd: add precommit checks to GitHub actions Dec 20, 2024
@jsstevenson jsstevenson marked this pull request as ready for review December 20, 2024 16:14
@jsstevenson jsstevenson marked this pull request as draft December 20, 2024 16:51
@jsstevenson jsstevenson marked this pull request as ready for review December 20, 2024 16:54
Copy link
Contributor

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'm not sure if we want to merge this if it results in removing GA4GH Digest documentation (for example, in Adjacency). Maybe for now we remove update-json-def-files from the action until we figure out what's happening?

@korikuzma
Copy link
Contributor

So I'm not sure if we want to merge this if it results in removing GA4GH Digest documentation (for example, in Adjacency). Maybe for now we remove update-json-def-files from the action until we figure out what's happening?

I tried running make all locally and none of the GA4GH Digest docs were removed

@jsstevenson
Copy link
Contributor Author

I see the problem. I just reverted + re-ran and I think it now captures what you're referencing.

@jsstevenson jsstevenson merged commit f84f91c into 2.0.0-ballot.2024-11 Jan 2, 2025
13 checks passed
@jsstevenson jsstevenson deleted the test-precommit branch January 2, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants