-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cicd: add precommit checks to GitHub actions #621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I'm not sure if we want to merge this if it results in removing GA4GH Digest documentation (for example, in Adjacency
). Maybe for now we remove update-json-def-files
from the action until we figure out what's happening?
I tried running |
I see the problem. I just reverted + re-ran and I think it now captures what you're referencing. |
(low priority)
I noticed in #622 that the latest commit on this branch seemed to be in violation of some precommit hooks, so small changes to the schema source were introducing downstream changes to a bunch of unrelated def/json files.
This PR
Higher order question as pointed out by @korikuzma in #622 : are all of these autogenerated changes correct (though it's also plausible that I'm messing it up somehow)?