Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate examples in documentation (#603) #625

Closed
wants to merge 6 commits into from

Conversation

srinitha709
Copy link

This pull request addresses issue #603 by automating the process of updating examples in the documentation. The following changes have been made:

  • Added scripts/update_examples.py to extract examples dynamically.
  • Updated docs/source/examples.rst to include extracted examples.
  • Added examples/example.py as a source for the examples.
  • Modified conf.py to support dynamic updates.
  • Included a GitHub Actions workflow in .github/workflows/update_docs.yml to automate this process.

Please review and let me know if further updates are needed.

CONTRIBUTING.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not related to this issue, so should be reverted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this workflow be empty?

docs/source/conf.py Outdated Show resolved Hide resolved
Comment on lines +36 to +37
source_file_path = 'examples/example.py' # Path to the source code file
doc_file_path = 'docs/source/examples.rst' # Path to the documentation file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I believe we would like to use our validation models that are defined here as the source and update the example section that corresponds to that model in docs/source/concepts.

For example, CopyNumberCount validation model would generate the docs example here. We'd want the docs example to also add the id field which is the out.ga4gh_identify field in the validation model.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification! I will use the validation models as the source for generating the documentation examples. specifically I will extract the relevant data from each model, including the out.ga4gh_identify field and update the example section in docs/source/concepts. I’ll proceed with implementing this and updating the documentation accordingly.

@srinitha709 srinitha709 closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants