Add enableCors option #75
Conversation
This passes the `--template=...` flag to the `git init` command. This allows config values and other defaults to be overwritten for newly created repositories.
This should allow me to publish it as a "scoped" package.
Missed publishing this and there's no way to update npm registry unfortunately...
|
@gabrielcsapo Finally getting back to you on these change requests. What would adding a test for this look like? Checking that the CORS headers really are added? Another approach would be to add something to the docs showing how to wrap this package in an express app and adding the cors headers there. That's the approach I've personally taken in one of my apps, as I want to handle some other URLs as well as the git stuff (got the idea in #58). |
|
An open-source middleware |
|
|
||
| # 0.6.2 (08/27/2020) | ||
|
|
||
| - Adds `repoTemplatePath` option |
There was a problem hiding this comment.
can we combine these changes into 0.6.2 instead of two releases?
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "node-git-server", | |||
| "version": "0.6.1", | |||
| "name": "@chmac/node-git-server", | |||
There was a problem hiding this comment.
can we change the name of the package back?
| "name": "node-git-server", | ||
| "version": "0.6.1", | ||
| "name": "@chmac/node-git-server", | ||
| "version": "0.6.3", |
|
@chmac I think an easy test would be enable CORS and ensure the headers are set. |
|
@gabrielcsapo I'm gonna close this. My fork has subsequently diverged further and it's gonna take quite a bit of effort to extract the changes back here, which is not something I have available time for at the moment. If somebody else wants to pick up on this PR / change, happy to support if I can, the code is all available on my fork. |
This is a naive approach to #53, but it seems to work for me.
I've published my fork including this and the other PRs that I've submitted as
@chmac/node-git-serverif you want to test that. I cherry picked the relevant commits into a separate branch to create a PR without the changes topackage.jsonandCHANGELOG.mdwhich you may or may not want to include.