Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleaning up MoveService #10

Merged
merged 33 commits into from
Nov 12, 2024
Merged

refactor: cleaning up MoveService #10

merged 33 commits into from
Nov 12, 2024

Conversation

gabrielg2020
Copy link
Owner

@gabrielg2020 gabrielg2020 commented Nov 6, 2024 •
edited
Loading

Description

After a lot of copying and pasting to create the piece moves, there is a lot of redundant/repetitive code (inc. test... 2000+ lines for one service 😮)

This PR will clean it up.

Type of Change

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature that might cause existing functionality to change)
  • Performance improvement
  • Other (refactoring)

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, especially in hard-to-understand areas.
  • I have updated the documentation where necessary.
  • My changes generate no new warnings or errors.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests pass.
  • My PR title follows the Conventional Commits specification.

@gabrielg2020
feat: added MoveService.addMove
d92d03e
@gabrielg2020
refactor: implement MoveService.addMove
6014c22 
Signed-off-by: Gabriel Guimaraes <[email protected]>
@gabrielg2020
feat: added MoveService.tryAddMove
0478616 
Signed-off-by: Gabriel Guimaraes <[email protected]>
@gabrielg2020
feat(test): added test for MoveService.tryAddMove
88bba13 
Signed-off-by: Gabriel Guimaraes <[email protected]>
@gabrielg2020
feat: added MoveService.generateMoves
11f81cd
@gabrielg2020
feat(test): added tests for MoveService.generateMoves
d68b7d2
@gabrielg2020
refactor: implement MoveService.generateMoves
10c427c
@gabrielg2020
refactor: move psudeo-move functionality into `MoveService.FindPseudo…
08cd43b 
…LegalMoves`

Signed-off-by: Gabriel Guimaraes <[email protected]>
@gabrielg2020
feat: add Chessboard.IsSquareUnderAttack
69ae813 
Signed-off-by: Gabriel Guimaraes <[email protected]>
@gabrielg2020
refactor: remove chessboard.IsSquareUnderAttack
8f073c1
@gabrielg2020
feat: add MoveService.canCastleKingSide & `MoveService.canCastleQue…
fc71484 
…enSide` & `MoveService.getCastlingMoves`
@gabrielg2020
feat: implement MoveService.getCastlingMoves
3fa5a22
@gabrielg2020
refactor: remove excess logging
4a4507e
@gabrielg2020
refactor: remove excess tests
691c5af
@gabrielg2020
feat(test): added test for MoveService.tryAddMove
6003128 
Signed-off-by: Gabriel Guimaraes <[email protected]>
@notion-workspace Notion Workspace
Copy link

Filter Legal Moves

@gabrielg2020
refactor: remove excess logging
6c95414 
Signed-off-by: Gabriel Guimaraes <[email protected]>
@gabrielg2020
fix: fix tryAddMove
0728481 
Signed-off-by: Gabriel Guimaraes <[email protected]>
@gabrielg2020
feat(test): added test for MoveService.generateMoves
a191e52 
Signed-off-by: Gabriel Guimaraes <[email protected]>
@gabrielg2020
feat(test): added test for MoveService.canCastleKingSide
67cf0d8 
Signed-off-by: Gabriel Guimaraes <[email protected]>
@gabrielg2020
feat(test): added test for MoveService.canCastleQueenSide
b935b30 
Signed-off-by: Gabriel Guimaraes <[email protected]>
@gabrielg2020
feat(test): added test for MoveService.getCastlingMoves
190bce4 
Signed-off-by: Gabriel Guimaraes <[email protected]>
@gabrielg2020
feat(test): added test for MoveService.getPawnMove
511014f 
Signed-off-by: Gabriel Guimaraes <[email protected]>
@gabrielg2020
feat(test): added test for MoveService.getKnightMove
41b2ccd 
Signed-off-by: Gabriel Guimaraes <[email protected]>
@gabrielg2020
feat(test): added test for MoveService.getBishopMove
7151ae2 
Signed-off-by: Gabriel Guimaraes <[email protected]>
@gabrielg2020
feat(test): added capture and block test MoveService.getKnightMove
19a8626 
Signed-off-by: Gabriel Guimaraes <[email protected]>
@gabrielg2020
refactor(test): cleaned up tests
0e412e2 
Signed-off-by: Gabriel Guimaraes <[email protected]>
@gabrielg2020
feat(test): added test for MoveService.getRookMove
41e6996 
Signed-off-by: Gabriel Guimaraes <[email protected]>
@gabrielg2020
feat(test): add move_service_test.massCreateEntities
a86d1db
@gabrielg2020
refactor(test): implement move_service_test.massCreateEntities
72549ad
@gabrielg2020 gabrielg2020 self-assigned this Nov 12, 2024
@gabrielg2020 gabrielg2020 merged commit d0bd2c5 into main Nov 12, 2024
5 checks passed
gabrielg2020 added a commit that referenced this pull request Nov 18, 2024
@gabrielg2020
Merge pull request #10 from gabrielg2020/refactoring-move-service
9e9dc7d 
refactor: cleaning up `MoveService`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gabrielg2020 gabrielg2020

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gabrielg2020