Add 'Show Group' #66
Open
Add 'Show Group' #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to 'Show User' this change will show the same popup but for a specific group.
| var group; | ||
| getJSON(`/api/v1/groups/${groupId}`).then(aGroup => { | ||
| group = aGroup; | ||
| $(".subheader").html(`${e(group.profile.name)}`); |
There was a problem hiding this comment.
there is no element with this css class. it exists for Users, but not for Groups
| document.title += ` - ${e(group.profile.name)} ${e(group.profile.description)}`; | ||
| }); | ||
| function showGroup() { | ||
| function toString(o, i = '') { |
There was a problem hiding this comment.
this code for toString was copied and pasted from showUser. it should be factored out.
also, indentation should be cleaned up
| const groupPopup = createPopup("Group"); | ||
| // It'd make sense to add group logos in here, however, if it's not `OKTA_GROUP`, it's `APP_GROUP` -so, no distinction between AD, Slack, etc. | ||
| // const logo = group.type == "OKTA_GROUP" ? "okta" : group.type.toLowerCase(); | ||
| groupPopup.html(`</span><br><pre>${e(toString(group))}</pre>`); |
| groupPopup.html(`</span><br><pre>${e(toString(group))}</pre>`); | ||
| } | ||
| createDiv("Show Group", mainPopup, showGroup); | ||
| createPrefixA("<li class=option>", "<span class='icon person-16-gray'></span>Show Group", ".okta-dropdown-list", showGroup); |
There was a problem hiding this comment.
this adds an item to the More Actions menu which exists for Users, but not for Groups
|
thanks for your PR. see comments above. please make sure you understand and test every line before submitting a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to 'Show User' this change will show the same popup but for a specific group.