Fix SSS Shader light leakage #297
Conversation
WalkthroughThe recent changes enhance code readability and robustness within the shader files. Specifically, naming conventions have been standardized by renaming a function to camelCase, while a conditional check has been added to improve shading calculations by preventing potential artifacts. These modifications ensure that the underlying logic remains intact, focusing on maintaining visual fidelity and code consistency. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/custom-material/src/advanced-shader/sss/SSSFunction.glsl (1 hunks)
- packages/custom-material/src/advanced-shader/sss/SSSLightDirect.glsl (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/custom-material/src/advanced-shader/sss/SSSFunction.glsl
Additional comments not posted (1)
packages/custom-material/src/advanced-shader/sss/SSSLightDirect.glsl (1)
30-33: LGTM! But verify the value ofEPSILON.The added conditional check ensures that the
specularLobefunction is only called whensurfaceData.dotNVis greater thanEPSILON, which prevents potential light leakage.However, ensure that the value of
EPSILONis appropriately defined to avoid unintended side effects.Verification successful
LGTM! The value of
EPSILONis appropriately defined as1e-6inpackages/shaderlab/src/shaders/Common.glsl.The added conditional check ensures that the
specularLobefunction is only called whensurfaceData.dotNVis greater thanEPSILON, which prevents potential light leakage. This value is small enough to avoid significant unintended side effects.
packages/shaderlab/src/shaders/Common.glsl:#define EPSILON 1e-6Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the value of `EPSILON` in the codebase. # Test: Search for the definition of `EPSILON`. Expect: The value should be appropriately defined. rg --type glsl -A 5 $'EPSILON'Length of output: 58
Script:
#!/bin/bash # Description: Verify the value of `EPSILON` in the codebase. # Test: Search for the definition of `EPSILON`. Expect: The value should be appropriately defined. rg 'EPSILON'Length of output: 571
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Summary by CodeRabbit
Bug Fixes
Style
MakeNormalizedSGtomakeNormalizedSG.