Allow libraries function set_permission public lib and dataset #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi Galaxy I work with this API methods using this library. Such a wonderful lib By the way, if I want to make the library and dataset public, I think we can adjust like I committed Long to hear if this will make the user feel better
| @@ -748,13 +748,13 @@ def set_library_permissions( | |||
| :return: General information about the library | |||
| """ | |||
| payload: Dict[str, List[str]] = {} | |||
| if access_in: | |||
There was a problem hiding this comment.
Before this test failed for access_in being None or []. Now only for None. Is this desired?
There was a problem hiding this comment.
I think [] make things unrestricted and is desired in create public data library.
There was a problem hiding this comment.
Can you add a test that shows this?
I'm also not entirely sure what you mean with "I want to make the library and dataset public". Has this not been possible before. Again, a test would be highly appreciated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Galaxy
I work with this API methods using this library. Such a wonderful lib By the way, if I want to make the library and dataset public, I think we can adjust like I committed Long to hear if this will make the user feel better