Skip to content

Commit

Permalink
improve wording of mixed format alert and add helptext
Browse files Browse the repository at this point in the history
Co-authored-by: John Chilton <[email protected]>
  • Loading branch information
ahmedhamidawan and jmchilton committed Jan 22, 2025
1 parent 2f034a5 commit d9fe6cd
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 9 deletions.
11 changes: 8 additions & 3 deletions client/src/components/Collections/ListCollectionCreator.vue
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { useDatatypesMapperStore } from "@/stores/datatypesMapperStore";
import localize from "@/utils/localization";
import FormSelectMany from "../Form/Elements/FormSelectMany/FormSelectMany.vue";
import HelpText from "../Help/HelpText.vue";
import CollectionCreator from "@/components/Collections/common/CollectionCreator.vue";
import DatasetCollectionElementView from "@/components/Collections/ListDatasetCollectionElementView.vue";
Expand Down Expand Up @@ -544,9 +545,13 @@ function renameElement(element: any, name: string) {
</template>

<template v-slot:middle-content>
<BAlert v-if="listHasMixedExtensions" show variant="warning">
{{ localize("The selected datasets have mixed extensions.") }}
{{ localize("You can still create the list but its elements will have different extensions.") }}
<BAlert v-if="listHasMixedExtensions" show variant="warning" dismissible>
{{ localize("The selected datasets have mixed formats.") }}
{{ localize("You can still create the list but generally") }}
{{ localize("dataset lists should contain datasets of the same type.") }}
<HelpText
uri="galaxy.collections.collectionBuilder.whyHomogenousCollections"
:text="localize('Why?')" />
</BAlert>
<div v-if="noInitialElements">
<BAlert show variant="warning" dismissible>
Expand Down
13 changes: 7 additions & 6 deletions client/src/components/Collections/PairCollectionCreator.vue
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import localize from "@/utils/localization";
import type { DatasetPair } from "../History/adapters/buildCollectionModal";
import DelayedInput from "../Common/DelayedInput.vue";
import HelpText from "../Help/HelpText.vue";
import DatasetCollectionElementView from "./ListDatasetCollectionElementView.vue";
import CollectionCreator from "@/components/Collections/common/CollectionCreator.vue";
Expand Down Expand Up @@ -517,12 +518,12 @@ function _naiveStartingAndEndingLCS(s1: string, s2: string) {
</span>
</BAlert>
<BAlert v-else-if="pairHasMixedExtensions" show variant="warning">
{{ localize("The selected datasets have mixed extensions.") }}
{{
localize(
"You can still create the pair but its elements will have different extensions."
)
}}
{{ localize("The selected datasets have mixed formats.") }}
{{ localize("You can still create the pair but generally") }}
{{ localize("dataset pairs should contain datasets of the same type.") }}
<HelpText
uri="galaxy.collections.collectionBuilder.whyHomogenousCollections"
:text="localize('Why?')" />
</BAlert>
<BAlert v-else show variant="success">
{{ localize("The Dataset Pair is ready to be created.") }}
Expand Down
9 changes: 9 additions & 0 deletions client/src/components/Help/terms.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,15 @@ galaxy:
these extensions. In the case of more than one extension, you can select a specific extension for
each individual file above. If there is only one extension, Galaxy will attempt to set that as the
extension for each file.
whyHomogenousCollections: |
Dataset collections are designed to streamline the analysis of large numbers of datasets by grouping
them together into a single, manageable entity. Unlike generic folders on your computer, which can hold
any mix of file types, dataset collections are specifically intended to be homogenous. This homogeneity
is crucial for consistency in processing. Homogeneous datasets ensure that each dataset in the collection
can be processed uniformly with the same tools and workflows. This eliminates the need for individual
adjustments, which can be time-consuming and prone to error. Most tools and workflows in Galaxy are designed
to operate on collections of similar data types. Homogeneous collections allow these tools to operate
uniformly over the collection.
jobs:
metrics:
Expand Down

0 comments on commit d9fe6cd

Please sign in to comment.