[WIP] SA2.0, model/data-access edits, unit testing #17662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdavcs
added
kind/bug
kind/enhancement
kind/refactoring
jmchilton
reviewed
Mar 12, 2024
| @@ -335,3 +337,12 @@ def serialize_job_state_summary(self, item, key, **context): | |||
| def serialize_elements_datatypes(self, item, key, **context): | |||
| extensions_set = item.dataset_dbkeys_and_extensions_summary[1] | |||
| return list(extensions_set) | |||
|
|
|||
|
|
|||
| def get_hdca_by_name(session, name): | |||
There was a problem hiding this comment.
This doesn't seem to belong in managers to me because it doesn't use trans or app. Also this code is only used in tests as far as I can grep - should just be moved to galaxy.model.unittest_utils.model_testing_utils or a new file like galaxy.model.unittest_utils.helpers. I think there is something jarring about seeing code like this mixed with app logic - I was immediately scared we were accessing data this way from the app.
jdavcs
force-pushed
the
dev_data_access
branch
3 times, most recently
from
0aba698 to
1ce7dfd
Compare
4 tasks
Tests SQLAlchemy: 1. Create tag 2. Verify there's no FooTagAssociation with this tag 3. Add new FooTagAssociation to Foo and save to db 4. Verify there is one FooTagAssociation with this tag
No assert (only TODO); but would test SQLAlchemy
Tests SQLAlchemy, user-history relationship mapping
Tests SQLAlchemy (create foo + set foo.bar + load foo + check bar)
This was referenced Apr 25, 2024
4 tasks
|
Superseded by #18312 (code review comments addressed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #17551 (accidentally deleted the remote branch due to slip of the finger)
Simple model and data-access unit testing. Db created and loaded once per session; cleared after each test. Dependent model instances created recursively as needed, with provided arguments or reasonable defaults.
Draft.
Builds on #17180.
How to test the changes?
(Select all options that apply)
License