Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable published item copy button when editing slug #17888

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

martenson
Copy link
Member

@martenson martenson commented Apr 2, 2024

resolves #17884

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we target 24.0 for the fix?
Disabling the button might also work.

@martenson
Copy link
Member Author

@davelopez Sure, I'll backport it.

As of disabling I'd rather hide it to unclutter the interface in this case.

@martenson martenson merged commit 0d3e8cd into galaxyproject:dev Apr 3, 2024
31 of 32 checks passed
@assuntad23
Copy link
Contributor

thanks @martenson !

@martenson martenson deleted the no-copy-edit branch April 4, 2024 21:59
@martenson martenson changed the title do not show published item copy button when editing slug disable published item copy button when editing slug Apr 5, 2024
@jdavcs jdavcs changed the title disable published item copy button when editing slug Disable published item copy button when editing slug May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sharing History allows you to copy a history link that is not valid
3 participants