[24.1] Fix display tags in FormSelect when available

[davelopez]

Fixes #18667

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. Follow the instructions in Dataset chooser does not show tags anymore #18667

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[davelopez]

Currently, the filtering will not take into account the tags, only the main "label". Did the previous component filter by tag too in the search box?

Edit: I figured out we should filter by tag anyway, people might remember the tag better than the dataset name. So I'll modify the default search to include tags.

[ElectronicBlueberry]

did you do a quick performance test for very large histories?

[davelopez]

Nope, if this was available before I just hope it shouldn't be worse than before. 😅

This is loading everything and is not (nor was) using any kind of pagination before I'm afraid.

[ElectronicBlueberry]

I'm worried mostly about the search, and how responsive it feels while typing. I think we have a filter worker which could be used here in case it's unresponsive.

[davelopez]

I think we have a filter worker which could be used here in case it's unresponsive.

Ahh cool! I'm happy to use it then. I'll search for it.

[davelopez]

It should be ready to review :)

[davelopez]

@ElectronicBlueberry, there is something about reusing the worker that breaks some selenium tests. I've tried for a long time to figure out what it is, but I can't see any problem with it 🤔

Do you think this is acceptable without reusing the worker as a fix? We can try to optimize it in the dev branch if this is a performance concern. What do you think?