[24.2] Fix to not display upload when creating collections from existing datasets.

[jmchilton]

I don't think the dialog option makes sense in that context and it consumes a lot of space. I love the feature overall and it makes perfect sense in the upload modal or when on the tool form and you don't have datasets in the history or you want to add new ones. But having the tab even when you've just selected some history contents or library contents I think feels off. There is a few refactorings of things to prevent a huge copy and paste inside and outside the tab component for this. There might be a better way to make tabbing optional - I'd be happy to hear it but these are still good refactorings I think (just not ideal for a bug fix on a stable release).

How to test the changes?

(Select all options that apply)

• This is a refactoring of components with existing test coverage.

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[ahmedhamidawan]

Thank you so much for these great improvements! Looks a lot cleaner now, and removing upload in that case makes sense.

[jmchilton]

@ahmedhamidawan Thanks for the review and I'm glad we are on the same page. Do have a better way to make the tabbing optional - the refactoring commits are good but that last commit is a hack? I minimized the copy-paste but there is still some and it has already caused me some headaches downstream in #19377. It is a dev branch concern not a 24.2 concern, but I thought I'd check while you are looking at this.