Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of User-Reported Dataset Error Emails #19401

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

hujambo-dunia
Copy link
Contributor

#17560

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

…or Page (for job-submissions) for separation between front/back-end code, easier development QA for reports/system emails, and component reusability.
@jdavcs
Copy link
Member

jdavcs commented Jan 13, 2025

Can you, please, reword the commit description as per our guidelines (https://github.com/galaxyproject/galaxy/blob/dev/CONTRIBUTING.md#how-to-contribute, item 6) - i.e., short imperative sentence, then space, followed by detailed description when needed). It really matters for working with git history and for release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants