Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Show message for mixed extensions in collection creator #19404

Open
wants to merge 8 commits into
base: release_24.2
Choose a base branch
from

Conversation

ahmedhamidawan
Copy link
Member

@ahmedhamidawan ahmedhamidawan commented Jan 13, 2025

Fixes #19277

mixed_extensions_collection_creator.mp4

Format explanation text also added to DatasetInformation:

... helptext link overs could be added. On format that describe it as having different names in Galaxy (dataytpe, format, extension) and explain the difference between file extensions of dataset datatypes and then reuse this help text in the history panel format label and dataset info format label.

Originally posted by @jmchilton in #19277

image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ahmedhamidawan ahmedhamidawan force-pushed the mixed_extensions_collection_creator branch from 921a861 to 150b0ea Compare January 22, 2025 19:19
and consolidate required formats indicator for create collection and upload files to collection in `CollectionCreatorShowExtensions`

Co-authored-by: Dannon <dannon.baker@gmail.com>
@ahmedhamidawan ahmedhamidawan force-pushed the mixed_extensions_collection_creator branch from 150b0ea to 49649d6 Compare January 22, 2025 19:20
@ahmedhamidawan ahmedhamidawan marked this pull request as ready for review January 22, 2025 19:33
@github-actions github-actions bot added this to the 25.0 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant