Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove transaction helper #19407

Open
wants to merge 39 commits into
base: dev
Choose a base branch
from
Open

Remove transaction helper #19407

wants to merge 39 commits into from
+658 −1,433

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Jan 14, 2025 •
edited
Loading

Follow-up to #19388

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs added kind/refactoring cleanup or refactoring of existing code, no functional changes area/testing area/database Galaxy's database or data access layer labels Jan 14, 2025
@jdavcs jdavcs added this to the 25.0 milestone Jan 14, 2025
@jdavcs jdavcs force-pushed the dev_remove_transaction_helper branch from a35ec8d to 86d046e Compare January 14, 2025 19:35
jdavcs and others added 16 commits January 14, 2025 14:57
@jdavcs @nsoranzo
Fix typo
ea87adf 
Co-authored-by: Nicola Soranzo <[email protected]>
@jdavcs
Remove transaction helper from galaxy.security
5042955
@jdavcs
Remove transaction helper from galaxy.model
a319a15
@jdavcs
Remove transaction helper from galaxy.tools
03a3d09
@jdavcs
Remove transaction helper from galaxy.job_execution
e729094
@jdavcs
Remove transaction helper from galaxy.managers
94ab8f5
@jdavcs
Remove transaction helper from galaxy.quota
0055485
@jdavcs
Remove transaction helper from galaxy.celery
132a9f0
@jdavcs
Remove transaction helper from galaxy.app_unittest_utils
f8ca76b
@jdavcs
Remove transaction helper from galaxy.work
e4a42aa
@jdavcs
Remove transaction helper from galaxy.authnz
d19ce82
@jdavcs
Remove transaction helper from galaxy.workflow
6708c37
@jdavcs
Remove transaction helper from galaxy.actions
551e20a
@jdavcs
Remove transaction helper from galaxy.jobs
e74511f
@jdavcs
Remove transaction helper from galaxy.web_stack
b3e353e
@jdavcs
Remove transaction helper from galaxy.webapps.base
6d38551
jdavcs added 15 commits January 14, 2025 17:14
@jdavcs
Remove transaction helper from galaxy.webapps.galaxy.api
0925b67
@jdavcs
Remove transaction helper from galaxy.webapps.galaxy.services
e7c599f
@jdavcs
Remove transaction helper from galaxy.webapps.galaxy.controllers
1bb2201
@jdavcs
Remove transaction helper from galaxy.tool_shed
e0f93ba
@jdavcs
Remove transaction helper from galaxy_test
7698575
@jdavcs
Remove transaction helper from tool_shed.webapp.security
fc96da4
@jdavcs
Remove transaction helper from tool_shed.webapp.api2
cfd38b9
@jdavcs
Remove transaction helper from tool_shed.webapp.util
75ee5cf
@jdavcs
Remove transaction helper from tool_shed.webapp.api
b53a1d3
@jdavcs
Remove transaction helper from tool_shed.webapp.controllers
dc412e6
@jdavcs
Remove transaction helper from tool_shed.managers
8413f08
@jdavcs
Remove transaction helper from tool_shed.metadata
56189ca
@jdavcs
Remove transaction helper from tool_shed.util
d4f3b6c
@jdavcs
Remove transaction helper from test/unit.test_galaxy_transactions
34d9fca
@jdavcs
Remove transaction helper
46163c9
@jdavcs jdavcs changed the title [WIP] Remove transaction helper Remove transaction helper Jan 14, 2025
@jdavcs jdavcs marked this pull request as ready for review January 14, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsoranzo nsoranzo nsoranzo left review comments

Assignees
No one assigned
Labels
area/database Galaxy's database or data access layer area/testing kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jdavcs @nsoranzo