Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add < otatadeabigail > as contributor #2846

Merged
merged 2 commits into from
Oct 22, 2021

Conversation

otatadeabigail
Copy link
Contributor

I'm an Outreachy applicant and I'm hoping to make positive contributions.

I'm an Outreachy applicant and I'm hoping to make positive contributions.
@bebatut
Copy link
Member

bebatut commented Oct 13, 2021

Hi @otatadeabigail , welcome to the GTN! Being on the contributor list is not a pre-requisite to contributing to the GTN.

So we do not add people to the contributor list until their first contribution to avoid inaccurately increasing our statistics. We will leave this pull request open until you make your first contribution and merge it then :)

If you are looking for ideas of how to contribute here, please take a look at this issue with contribution ideas, or have a chat with us on Gitter :)

@otatadeabigail
Copy link
Contributor Author

Okay and Thank you!

@hexylena
Copy link
Member

Hey @otatadeabigail you made your first contribution which is fantastic and we'd like to merge this now! Can you double check this PR please? It looks like you might have renamed the file,

@otatadeabigail
Copy link
Contributor Author

Oh, thank you. How do I check, it's the same one, I didn't rename the file

@hexylena
Copy link
Member

hexylena commented Oct 20, 2021

No worries! In the files tab I see this which looks like a rename.
image

Can you check your branch and make sure it's correct and update it otherwise?
https://github.com/otatadeabigail/training-material/tree/patch-2

@otatadeabigail
Copy link
Contributor Author

I've seen it. Yes it is

@otatadeabigail
Copy link
Contributor Author

It's correct and up to date

@bebatut
Copy link
Member

bebatut commented Oct 20, 2021

The change does not appear here. Did you make a new commit? Did you push your changes?

@otatadeabigail
Copy link
Contributor Author

Looks like I might have just deleted the changed file instead while trying to click 'view file'

@otatadeabigail
Copy link
Contributor Author

Will that make it impossible to merge?

@otatadeabigail
Copy link
Contributor Author

What do I need to do now please? Sorry for the inconvenience, 😔

@hexylena
Copy link
Member

No worries @otatadeabigail! I renamed the file on your branch and added you. Can you check that it looks ok? https://github.com/galaxyproject/training-material/pull/2846/files And feel free to add any of the other fields.

@otatadeabigail
Copy link
Contributor Author

@hexylena Thank you. It's perfect!

@hexylena hexylena merged commit 9e0d8c0 into galaxyproject:main Oct 22, 2021
@hexylena
Copy link
Member

awesome! Thank you, and welcome to the GTN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants