Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 5.3, fixed wrong paths, added ref to custom overrides #193

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

thexmanxyz
Copy link
Contributor

@thexmanxyz thexmanxyz commented Oct 24, 2019

Hey there,

I noticed a typo concerning the Grav path for engine files under 5.3.

Please see the first screenshot which shows the section with the error (located here) as well as the second screenshot with the correct path (located here).

Please carefully compare it with the file overrides chapter.

Wrong Path (5.3):
grafik

Correct Path (5.6):
grafik

Thanks and credits to @ChrystalSolutions who noticed the error as well.

Edit: Additionally I fixed some path inconsistencies and added a reference to chapter 5.6

@thexmanxyz thexmanxyz changed the title Chapter 5.3 wrong path for engine files Chapter 5.3, wrong path for engine files Oct 24, 2019
@thexmanxyz
Copy link
Contributor Author

thexmanxyz commented Oct 24, 2019

@marktaylor46 @RyanMPierson Tagging people! Please merge ASAP as this mistake is a very confusing one for users!

@simmonsr
Copy link
Contributor

you should add user/data/gantry5/themes to the path

@thexmanxyz
Copy link
Contributor Author

thexmanxyz commented Oct 25, 2019

@simmonsr I deleted now my previous comment, you are totally right, I will now adapt the path for Grav. For Joomla and WP the paths are also starting in the root directory of the CMS. I thought they weren't. I will add a commit soon. Moreover I will now also add a reference on chapter 5.6 so that users can directly jump to the file overrides chapter were everything concerning override paths is explained. I think this is useful and should be outlined in chapter 5.3 as well.

@thexmanxyz thexmanxyz changed the title Chapter 5.3, wrong path for engine files Chapter 5.3, fixed wrong paths, added ref to custom overrides Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants