Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: Styles appearing according to the available sections of the outline layout #2357

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joomlabeat
Copy link

This PR addresses #2246

Now the Section Styles for the selected outline depend on the available sections of the outline layout.

*I have only tested this with a WP custom theme that I am building.

@mahagr
Copy link
Member

mahagr commented Sep 6, 2018

@joomlabeat Should base outline have every style option, though?

@joomlabeat
Copy link
Author

joomlabeat commented Sep 6, 2018

@mahagr - So far yes, the concept is that the base outline features all sections and styles. This is my conclusion as the best way to build templates, which in someway gantry forces us, as then all the other outlines usually inherit staff from the base, even if the have less sections.
So base outline seems to be the base of everything, which tends to feel like an acceptable convention.
I haven't tested my solution with the base not having all the sections. Do you think it would give any issues with scss?
I could test it in the coming days. Let me know if there is anything else I should take into consideration.

@mahagr mahagr force-pushed the master branch 2 times, most recently from c317a60 to 69e9104 Compare September 11, 2018 07:04
@mahagr mahagr force-pushed the master branch 3 times, most recently from 7502796 to aad94c0 Compare June 21, 2019 15:48
@mahagr mahagr force-pushed the master branch 2 times, most recently from 85cbce4 to 8839d62 Compare April 30, 2020 09:54
@mahagr mahagr force-pushed the master branch 2 times, most recently from 9cd87e8 to 3f4c958 Compare November 3, 2021 21:20
@mahagr mahagr force-pushed the master branch 2 times, most recently from c9a5a72 to 6b36aaa Compare January 26, 2022 10:52
@mahagr mahagr force-pushed the master branch 3 times, most recently from 1d738f2 to de92b9d Compare February 15, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants