CI: Use Pkg.jl for installing GAP.jl #5735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somehow the new CI job doesn't run on this PR at all, so I cannot test it. @fingolfin do you have any idea why? |
fingolfin
reviewed
Jun 4, 2024
fingolfin
reviewed
Jun 4, 2024
lgoettgens
force-pushed
the
lg/gapjl-ci
branch
4 times, most recently
from
f1ff104 to
c324313
Compare
|
Testing against the GAP.jl master still works. Testing with the latest release will keep failing until the change in oscar-system/GAP.jl#995 (comment) is released. |
|
WIth the new Gap.jl 0.11.1 release, all jobs now succeed. |
fingolfin
approved these changes
Jun 7, 2024
fingolfin
changed the title
fingolfin
added
release notes: not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5733.
This is currently WIP.I am trying to adapt this as suggested in #5733 (comment).
Text for release notes
none