Create ExerciseComment database table #2404

HS-90 · 2022-10-06T16:45:48Z

Description: relates to #2400

This PR creates the backend data structure in prisma/PostgreSQL.

This sets up the relational database between Discussions, Exercises, and Users. This also includes a self relation for the replies property.

vercel · 2022-10-06T16:45:53Z

@HS-90 is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

HS-90 · 2022-10-06T16:47:20Z

prisma/migrations/20221006161545_create_discussions_table2/migration.sql

@@ -0,0 +1,2 @@
+-- AlterTable
+ALTER TABLE "Discussion" ALTER COLUMN "userPic" DROP NOT NULL;


Setting userPic to not null, since not every user may have uploaded a profile picture

prisma/migrations/20221006163340_create_discussions_table3/migration.sql

codecov · 2022-10-06T16:53:43Z

Codecov Report

Merging #2404 (f62ccc2) into master (c0e1f96) will not change coverage.
The diff coverage is n/a.

❗ Current head f62ccc2 differs from pull request most recent head 9bacfc3. Consider uploading reports for the commit 9bacfc3 to get more accurate results

@@            Coverage Diff            @@
##            master     #2404   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          185       185           
  Lines         3292      3292           
  Branches       874       888   +14     
=========================================
  Hits          3292      3292

flacial · 2022-10-06T16:57:42Z

prisma/schema.prisma

@@ -207,3 +209,19 @@ model ExerciseSubmission {

  @@map("exerciseSubmissions")
 }
+
+model Discussion {


I'm a little bit confused by naming this table Discussion. Wouldn't Comment make more sense?

I feel Discussion refer to the feature whilst a Comment refer to the comments in the Discussion.

Open to suggestions about naming it something different but there's already a Comment table.

What about DiscussionComment?

Lets finalize all these details before implementation. After implementing this model, we should not have to be touching this model in the backend anymore to finish implementing a MVP for the discussions flow

Lets finalize all these details before implementation. After implementing this model, we should not have to be touching this model in the backend anymore to finish implementing a MVP for the discussions flow

What do you mean by "finalize"? And when is a design doc is considered complete?

If we are following a design doc, all of the architecture should be decided upon before implementation. By finalized details I mean complete design doc. What a complete design doc looks like will differ depending on what feature the design doc was made for. Here are good tips on design docs, it's also in our engineering practices
https://www.industrialempathy.com/posts/design-docs-at-google/

For this discussions flow design doc, enough should be outlined such that the backend and frontend can start work in parallel. If we are still deciding on how the backend should be setup, then that means the frontend can't be worked on yet since the frontend relies on how the backend is setup

prisma/schema.prisma

anthonykhoa · 2022-10-06T18:10:45Z

Are we certain that this discussions table model in the backend will not have to be changed anymore in order to complete the Discussions flow?

HS-90 · 2022-10-06T18:43:31Z

Are we certain that this discussions table model in the backend will not have to be changed anymore in order to complete the Discussions flow?

I think we will have to add an isMain, but otherwise it has what we would need.
It has unique identifiers, self relation with the ability to nest responses, relational database with Exercise and User(author).

Although do we want the replies to automatically inherit the exerciseId from it's parent? Or is that something we would do with a resolver in GraphQL?

Also, would it be better to have a username property? Or just get the username from author(User)

anthonykhoa · 2022-10-06T19:41:43Z

I think we will have to add an isMain, but otherwise it has what we would need. It has unique identifiers, self relation with the ability to nest responses, relational database with Exercise and User(author).

Although do we want the replies to automatically inherit the exerciseId from it's parent? Or is that something we would do with a resolver in GraphQL?

Also, would it be better to have a username property? Or just get the username from author(User)

Looks like the architecture hasn't been finalized yet. Let's get answers to all the open questions you have before implementation.

vercel · 2022-10-14T19:05:18Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
c0d3-app	✅ Ready (Inspect)	Visit Preview	Oct 19, 2022 at 8:56PM (UTC)

prisma/schema.prisma

flacial

Looks good to me. Apply the comments before merging.

create discussions table in prisma

d7d2f5e

HS-90 added enhancement New feature or request DB labels Oct 6, 2022

HS-90 commented Oct 6, 2022

View reviewed changes

prisma/migrations/20221006163340_create_discussions_table3/migration.sql Show resolved Hide resolved

flacial reviewed Oct 6, 2022

View reviewed changes

prisma/schema.prisma Show resolved Hide resolved

Merge branch 'master' into discussions-backend

488fe1a

flacial and others added 4 commits October 10, 2022 21:24

Merge branch 'master' into discussions-backend

f5a3e8f

Merge branch 'garageScript:master' into discussions-backend

ebf3d8c

Merge branch 'garageScript:master' into discussions-backend

9c43845

revision to Discussions table after team meeting

b15b3c8

vercel bot deployed to Preview October 14, 2022 19:10 View deployment

flacial reviewed Oct 15, 2022

View reviewed changes

prisma/schema.prisma Outdated Show resolved Hide resolved

flacial reviewed Oct 15, 2022

View reviewed changes

prisma/schema.prisma Outdated Show resolved Hide resolved

flacial approved these changes Oct 15, 2022

View reviewed changes

HS-90 and others added 2 commits October 16, 2022 10:49

Merge branch 'master' into discussions-backend

fbb00cd

change ExerciseComments to ExerciseComment

76e3554

vercel bot deployed to Preview October 16, 2022 16:09 View deployment

Merge branch 'master' into discussions-backend

0955ccc

flacial requested a review from anthonykhoa October 17, 2022 17:18

vercel bot deployed to Preview October 17, 2022 18:18 View deployment

Merge branch 'master' into discussions-backend

e660fab

vercel bot deployed to Preview October 19, 2022 14:46 View deployment

Merge branch 'master' into discussions-backend

9bacfc3

vercel bot deployed to Preview October 19, 2022 20:56 View deployment

HS-90 merged commit ccb6f47 into garageScript:master Oct 19, 2022

flacial changed the title ~~Create Discussions table in Prisma~~ Create ExerciseComment table in Prisma Oct 23, 2022

flacial changed the title ~~Create ExerciseComment table in Prisma~~ Create ExerciseComment database table Oct 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create ExerciseComment database table #2404

Create ExerciseComment database table #2404

HS-90 commented Oct 6, 2022

vercel bot commented Oct 6, 2022

HS-90 Oct 6, 2022

codecov bot commented Oct 6, 2022 •

edited

Loading

flacial Oct 6, 2022

flacial Oct 6, 2022

HS-90 Oct 6, 2022

flacial Oct 6, 2022

anthonykhoa Oct 6, 2022 •

edited

Loading

flacial Oct 6, 2022 •

edited

Loading

anthonykhoa Oct 7, 2022 •

edited

Loading

anthonykhoa commented Oct 6, 2022

HS-90 commented Oct 6, 2022 •

edited

Loading

anthonykhoa commented Oct 6, 2022 •

edited

Loading

vercel bot commented Oct 14, 2022 •

edited

Loading

flacial left a comment

		@@ -0,0 +1,2 @@
		-- AlterTable
		ALTER TABLE "Discussion" ALTER COLUMN "userPic" DROP NOT NULL;

Create ExerciseComment database table #2404

Create ExerciseComment database table #2404

Conversation

HS-90 commented Oct 6, 2022

vercel bot commented Oct 6, 2022

HS-90 Oct 6, 2022

Choose a reason for hiding this comment

codecov bot commented Oct 6, 2022 • edited Loading

Codecov Report

flacial Oct 6, 2022

Choose a reason for hiding this comment

flacial Oct 6, 2022

Choose a reason for hiding this comment

HS-90 Oct 6, 2022

Choose a reason for hiding this comment

flacial Oct 6, 2022

Choose a reason for hiding this comment

anthonykhoa Oct 6, 2022 • edited Loading

Choose a reason for hiding this comment

flacial Oct 6, 2022 • edited Loading

Choose a reason for hiding this comment

anthonykhoa Oct 7, 2022 • edited Loading

Choose a reason for hiding this comment

anthonykhoa commented Oct 6, 2022

HS-90 commented Oct 6, 2022 • edited Loading

anthonykhoa commented Oct 6, 2022 • edited Loading

vercel bot commented Oct 14, 2022 • edited Loading

flacial left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 6, 2022 •

edited

Loading

anthonykhoa Oct 6, 2022 •

edited

Loading

flacial Oct 6, 2022 •

edited

Loading

anthonykhoa Oct 7, 2022 •

edited

Loading

HS-90 commented Oct 6, 2022 •

edited

Loading

anthonykhoa commented Oct 6, 2022 •

edited

Loading

vercel bot commented Oct 14, 2022 •

edited

Loading