Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test cardinality #1119

Merged
merged 3 commits into from
Nov 7, 2024
Merged

fix test cardinality #1119

merged 3 commits into from
Nov 7, 2024

Conversation

kon-angelo
Copy link
Contributor

@kon-angelo kon-angelo commented Nov 5, 2024 •
edited
Loading

How to categorize this PR?

/area control-plane
/kind test
/platform aws

What this PR does / why we need it:

  • Make VPC deletion of the test more robust
  • Deletion of infra is needed to count a test as passed
  • Deletion of infra occurs after each test (and not at the end of the suite)

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kon-angelo
Copy link
Contributor Author

/test

@gardener-robot gardener-robot added the platform/aws Amazon web services platform/infrastructure label Nov 5, 2024
@gardener-robot
Copy link

@kon-angelo Labels area/todo, kind/todo do not exist.

@testmachinery
Copy link

testmachinery bot commented Nov 5, 2024 •
edited
Loading

Testrun: e2e-llqt4
Workflow: e2e-llqt4-wf
Phase: Failed

+---------------------+-----------------------------+-----------+----------+
|        NAME         |            STEP             |   PHASE   | DURATION |
+---------------------+-----------------------------+-----------+----------+
| dnsrecord-test      | dnsrecord-test              | Succeeded | 6m33s    |
| infrastructure-test | infrastructure-test-tf      | Failed    | 34m52s   |
| infrastructure-test | infrastructure-test-flow    | Failed    | 21m46s   |
| infrastructure-test | infrastructure-test-migrate | Failed    | 32m2s    |
| infrastructure-test | infrastructure-test-recover | Failed    | 21m39s   |
| bastion-test        | bastion-test                | Succeeded | 5m27s    |
+---------------------+-----------------------------+-----------+----------+

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 5, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 5, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 5, 2024
@kon-angelo
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Nov 5, 2024 •
edited
Loading

Testrun: e2e-tx2ks
Workflow: e2e-tx2ks-wf
Phase: Failed

+---------------------+-----------------------------+-----------+----------+
|        NAME         |            STEP             |   PHASE   | DURATION |
+---------------------+-----------------------------+-----------+----------+
| infrastructure-test | infrastructure-test-tf      | Failed    | 3m29s    |
| infrastructure-test | infrastructure-test-flow    | Failed    | 4m11s    |
| infrastructure-test | infrastructure-test-migrate | Failed    | 3m59s    |
| infrastructure-test | infrastructure-test-recover | Failed    | 3m28s    |
| bastion-test        | bastion-test                | Succeeded | 9m44s    |
| dnsrecord-test      | dnsrecord-test              | Succeeded | 6m54s    |
+---------------------+-----------------------------+-----------+----------+

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 5, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 5, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 5, 2024
@kon-angelo
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Nov 5, 2024 •
edited
Loading

Testrun: e2e-9dgtz
Workflow: e2e-9dgtz-wf
Phase: Failed

+---------------------+-----------------------------+-----------+----------+
|        NAME         |            STEP             |   PHASE   | DURATION |
+---------------------+-----------------------------+-----------+----------+
| infrastructure-test | infrastructure-test-flow    | Failed    | 29m21s   |
| infrastructure-test | infrastructure-test-migrate | Failed    | 29m36s   |
| infrastructure-test | infrastructure-test-recover | Failed    | 25m55s   |
| bastion-test        | bastion-test                | Succeeded | 9m11s    |
| dnsrecord-test      | dnsrecord-test              | Succeeded | 6m30s    |
| infrastructure-test | infrastructure-test-tf      | Failed    | 10m20s   |
+---------------------+-----------------------------+-----------+----------+

@gardener-robot gardener-robot added the area/control-plane Control plane related label Nov 5, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 5, 2024
@gardener-robot
Copy link

@kon-angelo Label kind/testing does not exist.

@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 5, 2024
@kon-angelo
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Nov 5, 2024 •
edited
Loading

Testrun: e2e-hgtd4
Workflow: e2e-hgtd4-wf
Phase: Failed

+---------------------+-----------------------------+-----------+----------+
|        NAME         |            STEP             |   PHASE   | DURATION |
+---------------------+-----------------------------+-----------+----------+
| infrastructure-test | infrastructure-test-tf      | Failed    | 32m40s   |
| infrastructure-test | infrastructure-test-flow    | Failed    | 9m42s    |
| infrastructure-test | infrastructure-test-migrate | Failed    | 47m11s   |
| infrastructure-test | infrastructure-test-recover | Failed    | 4m46s    |
| bastion-test        | bastion-test                | Succeeded | 7m15s    |
| dnsrecord-test      | dnsrecord-test              | Succeeded | 6m42s    |
+---------------------+-----------------------------+-----------+----------+

@kon-angelo
Copy link
Contributor Author

/test

@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Nov 6, 2024
@testmachinery
Copy link

testmachinery bot commented Nov 6, 2024 •
edited
Loading

Testrun: e2e-7jt7v
Workflow: e2e-7jt7v-wf
Phase: Failed

+---------------------+-----------------------------+-----------+----------+
|        NAME         |            STEP             |   PHASE   | DURATION |
+---------------------+-----------------------------+-----------+----------+
| infrastructure-test | infrastructure-test-tf      | Failed    | 3m12s    |
| infrastructure-test | infrastructure-test-flow    | Failed    | 3m31s    |
| infrastructure-test | infrastructure-test-migrate | Failed    | 3m45s    |
| infrastructure-test | infrastructure-test-recover | Failed    | 3m16s    |
| bastion-test        | bastion-test                | Succeeded | 4m56s    |
| dnsrecord-test      | dnsrecord-test              | Succeeded | 6m43s    |
+---------------------+-----------------------------+-----------+----------+

@gardener-robot gardener-robot removed the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Nov 6, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 6, 2024
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 6, 2024
@kon-angelo
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Nov 6, 2024 •
edited
Loading

Testrun: e2e-mnfws
Workflow: e2e-mnfws-wf
Phase: Succeeded

+---------------------+-----------------------------+-----------+----------+
|        NAME         |            STEP             |   PHASE   | DURATION |
+---------------------+-----------------------------+-----------+----------+
| infrastructure-test | infrastructure-test-flow    | Succeeded | 27m32s   |
| infrastructure-test | infrastructure-test-migrate | Succeeded | 32m10s   |
| infrastructure-test | infrastructure-test-recover | Succeeded | 28m23s   |
| bastion-test        | bastion-test                | Succeeded | 5m24s    |
| dnsrecord-test      | dnsrecord-test              | Succeeded | 6m46s    |
| infrastructure-test | infrastructure-test-tf      | Succeeded | 35m58s   |
+---------------------+-----------------------------+-----------+----------+

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 6, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 6, 2024
@gardener-robot
Copy link

@kon-angelo Label kind/testing does not exist.

@kon-angelo kon-angelo marked this pull request as ready for review November 6, 2024 14:51
@kon-angelo kon-angelo requested review from a team as code owners November 6, 2024 14:51
hebelsan
hebelsan approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 7, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 7, 2024
@kon-angelo kon-angelo merged commit 50e77ed into gardener:master Nov 7, 2024
17 checks passed
@kon-angelo kon-angelo deleted the fix-test-cardinality branch November 7, 2024 09:17
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hebelsan hebelsan hebelsan approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/test Test needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kon-angelo @gardener-robot @hebelsan @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3