[GEP 31] Introduce API changes for supporting InPlaceUpdate #962
+534
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
kind/api-change
gardener-robot-ci-2
added
reviewed/ok-to-test
|
/invite @unmarshall @rishabh-11 |
11 tasks
|
/invite @elankath @aaronfern |
unmarshall
reviewed
Jan 24, 2025
acumino
force-pushed
the
inplace-updates/api
branch
from
69a6063 to
7fd974d
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
shafeeqes
reviewed
Feb 4, 2025
Co-authored-by: Shafeeque E S <[email protected]> Co-authored-by: Ashish Ranjan Yadav <[email protected]>
Co-authored-by: Shafeeque E S <[email protected]> Co-authored-by: Ashish Ranjan Yadav <[email protected]>
Co-authored-by: Shafeeque E S <[email protected]> Co-authored-by: Ashish Ranjan Yadav <[email protected]>
Co-authored-by: Shafeeque E S <[email protected]> Co-authored-by: Ashish Ranjan Yadav <[email protected]>
acumino
force-pushed
the
inplace-updates/api
branch
from
7fd974d to
03e077f
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Co-Authored-By: Shafeeque E S <[email protected]> Co-Authored-By: Ashish Ranjan Yadav <[email protected]>
acumino
force-pushed
the
inplace-updates/api
branch
from
6520185 to
63ca186
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
aaronfern
reviewed
Feb 12, 2025
| if spec.Strategy.Type == machine.InPlaceUpdateMachineDeploymentStrategyType { | ||
| if spec.Strategy.InPlaceUpdate == nil { | ||
| allErrs = append(allErrs, field.Required(fldPath.Child("strategy.inPlaceUpdate"), "InPlaceUpdate parameter cannot be nil for in-place update strategy")) | ||
| } else { |
There was a problem hiding this comment.
Do we not want some validation for spec.Strategy.InPlaceUpdate.OrchestrationType? From what I understood it should only take values Auto or Manual
Comment on lines
+23
to
+44
| const ( | ||
| // GroupName is the group name use in this package | ||
| GroupName = "machine.sapcloud.io" | ||
|
|
||
| // AnnotationKeyMachineUpdateFailedReason is the annotation key for the machine indicating the reason for the machine update failure. | ||
| AnnotationKeyMachineUpdateFailedReason = "node.machine.sapcloud.io/update-failed-reason" | ||
|
|
||
| // LabelKeyMachineCandidateForUpdate is the label key for the machine indicating the machine will undergo an update. | ||
| LabelKeyMachineCandidateForUpdate = "node.machine.sapcloud.io/candidate-for-update" | ||
| // LabelKeyMachineSelectedForUpdate is the label key for the machine indicating the machine is selected for update. | ||
| LabelKeyMachineSelectedForUpdate = "node.machine.sapcloud.io/selected-for-update" | ||
| // LabelKeyMachineReadyForUpdate is the label key for the machine indicating the machine is ready for update after the node drain. | ||
| LabelKeyMachineReadyForUpdate = "node.machine.sapcloud.io/ready-for-update" | ||
| // LabelKeyMachineDrainSuccessful is the label key for the machine indicating the node drain was successful. | ||
| LabelKeyMachineDrainSuccessful = "node.machine.sapcloud.io/drain-successful" | ||
| // LabelKeyMachineUpdateSuccessful is the label key for the machine indicating the machine update was successful. | ||
| LabelKeyMachineUpdateSuccessful = "node.machine.sapcloud.io/update-successful" | ||
| // LabelKeyMachineUpdateFailed is the label key for the machine indicating the machine update failed. | ||
| LabelKeyMachineUpdateFailed = "node.machine.sapcloud.io/update-failed" | ||
| // LabelKeyMachineSetSkipUpdate is the label key for the machine indicating the machine set update should be skipped. | ||
| LabelKeyMachineSetSkipUpdate = "node.machine.sapcloud.io/machine-set-skip-update" | ||
| ) |
There was a problem hiding this comment.
Are you sure this is the right file for these constants?
To me machine_types.go seems more apt, or even a new file constants.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces the necessary API changes to enable in-place updates for nodes, as outlined in gardener/gardener#10219.
Which issue(s) this PR fixes:
Part of #944
Part of gardener/gardener#10219
Special notes for your reviewer:
Release note: