Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add support for threshold lower bound #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrerun
Copy link
Contributor

What this PR does / why we need it:
Threshold scales proportionally to PVC capacity. With small volumes, a reasonable threshold percentage can turn into an absolute value too small to accommodate the workload's occasional storage allocation bursts. This enhancement adds support for a new, optional parameter (PVC anotation) - an absolute lower bound for threshold.

Release note:

Support was added for a new scaling parameter (PVC annotation): `pvc.autoscaling.gardener.cloud/min-threshold`.

@andrerun andrerun requested a review from a team as a code owner November 13, 2024 13:21
@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 13, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 13, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 13, 2024
Copy link
Member

@dnaeon dnaeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Nov 26, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 26, 2024
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Dec 2, 2024
@gardener-robot
Copy link
Contributor

@andrerun You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot removed the reviewed/lgtm Has approval for merging label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants