Skip to content

Commit

Permalink
test_kmod: fix small memory leak on filesystem tests
Browse files Browse the repository at this point in the history
The break was in the wrong place so file system tests don't work as
intended, leaking memory at each test switch.

[[email protected]: massaged commit subject, noted memory leak issue without the fix]
Link: http://lkml.kernel.org/r/[email protected]
Fixes: 39258f448d71 ("kmod: add test driver to stress test the module loader")
Signed-off-by: Dan Carpenter <[email protected]>
Signed-off-by: Luis R. Rodriguez <[email protected]>
Reported-by: David Binderman <[email protected]>
Cc: Colin Ian King <[email protected]>
Cc: Dmitry Torokhov <[email protected]>
Cc: Eric W. Biederman <[email protected]>
Cc: Jessica Yu <[email protected]>
Cc: Josh Poimboeuf <[email protected]>
Cc: Kees Cook <[email protected]>
Cc: Michal Marek <[email protected]>
Cc: Miroslav Benes <[email protected]>
Cc: Petr Mladek <[email protected]>
Cc: Rusty Russell <[email protected]>
Cc: Shuah Khan <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Dan Carpenter authored and torvalds committed Aug 10, 2017
1 parent 9c56771 commit 4e98ebe
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/test_kmod.c
Original file line number Diff line number Diff line change
Expand Up @@ -746,11 +746,11 @@ static int trigger_config_run_type(struct kmod_test_device *test_dev,
strlen(test_str));
break;
case TEST_KMOD_FS_TYPE:
break;
kfree_const(config->test_fs);
config->test_driver = NULL;
copied = config_copy_test_fs(config, test_str,
strlen(test_str));
break;
default:
mutex_unlock(&test_dev->config_mutex);
return -EINVAL;
Expand Down

0 comments on commit 4e98ebe

Please sign in to comment.