updated fees.. added links to fee schedules adjacent to fee variable … #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…declarations in exchange wrappers qqq
|
Looks pretty good but this broke the unit tests, as can be seen in the 'checks' section here. Should be a simple fix to change the default fees in those files too. https://travis-ci.com/garethdmm/gryphon/builds/147009417 |
|
Thanks, not sure why it didn't come up when I ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updated all the fees in the exchange wrappers. Also added links to the fee tables for each exchange right next to the market and limit order fee variables.
Inspired by Issue # 42, specifically "keep reference links around in the source, and rely on a developer modifying the default values when the exchange happens to change its fees policy."