Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tower_http clippy warning #125

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Aug 16, 2024

Fixes the unreachable pattern clippy warning at https://github.com/gaucho-labs/leptos-hotkeys/pull/124/files#file-examples-ssr-demo-src-fileserv-rs-L35.

For details see leptos-rs/start-axum#47. Also implemented the change included in leptos-rs/start-axum#41

Copy link
Member

@friendlymatthew friendlymatthew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So awesome!

Should I add this in the changelog?

@friendlymatthew friendlymatthew mentioned this pull request Aug 16, 2024
9 tasks
@mondeja
Copy link
Collaborator Author

mondeja commented Aug 16, 2024

Nope, it's just for the example.

@mondeja mondeja merged commit 6adff72 into gaucho-labs:main Aug 16, 2024
7 checks passed
@mondeja mondeja deleted the fix-tower-http-warning branch August 16, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants