Use key() as keyboard identifier, Catch spacebar str::trim edgecase
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friendlymatthew
approved these changes
Aug 17, 2024
There was a problem hiding this comment.
Thanks you!
@mondeja I'm going to merge this as is. I have some follow up PRs that I can add on to get this fully over the line
This was referenced Aug 17, 2024
Open
friendlymatthew
changed the title
key() as keyboard identifier, Catch spacebar str::trim edgecase
maxbergmark
added a commit
to maxbergmark/leptos-hotkeys
that referenced
this pull request
Aug 17, 2024
|
@all-contributors please add @rkimoakbioinformatics for code |
|
I've put up a pull request to add @rkimoakbioinformatics! 🎉 |
maxbergmark
added a commit
that referenced
this pull request
Sep 3, 2024
* First attempt at fixing #119 * Reset last_pressed on key up + refactor * Refactor key handling logic * Handle conflict with #127 * Temporary debug message for last key match * Another temporary debug message * Remove temporary logs + refactor * Add feature for using event key * Update README with feature flag description * Revert "Update README with feature flag description" This reverts commit f721c9b. * Revert "Add feature for using event key" This reverts commit f1e5410. --------- Co-authored-by: Matthew Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed from .code() to .keys() so that alternative keyboard layouts are correctly detected.
Made str::trim to run conditionally so that the space key is detected.