Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note: Add the ability to set template format to "compact". #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

esden
Copy link
Collaborator

@esden esden commented Sep 8, 2024

As far as the notecard documentation goes there currently only seems to be a None or "compact" formats. https://dev.blues.io/api-reference/notecard-api/note-requests/latest/#note-template

But it probably make sense to leave this to be a string so if blues decides to add more formats it will be easy to use? But we can discuss using some kind of an Enum instead if that makes more sense.

@gauteh
Copy link
Owner

gauteh commented Sep 9, 2024

Thanks. I think a enum sounds good, we could make it open-ended (there is some rust way of doing this). Or even support a Custom(String) member, but I'm not sure this is necessary. If the API doesn't change more than the rest we can just have an enum and add new members as they pop up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants