Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unescape query id in http handlers #58

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Conversation

gazenw
Copy link
Member

@gazenw gazenw commented Oct 6, 2024

Description

Spacers are url-encoded in req.Id, causing it to fail rune name validation if req.Id contains it. This PR unescapes the parameter before validating and using

Type of change

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Enhancement (improvement to existing features and functionality)
  • Documentation update (changes to documentation)
  • Performance improvement (non-breaking change which improves efficiency)
  • Code consistency (non-breaking change which improves code reliability and robustness)

Commit formatting

Please follow the commit message conventions for an easy way to identify the purpose or intention of a commit. Check out our commit message conventions in the CONTRIBUTING.md

@gazenw gazenw merged commit e1f8eaa into develop Oct 6, 2024
8 checks passed
@gazenw gazenw deleted the fix/rune-name-check branch October 6, 2024 12:59
@gazenw gazenw mentioned this pull request Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant