feat: add get Runes info batch api #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Planxnx
reviewed
Oct 29, 2024
| @@ -90,7 +91,7 @@ func (h *HttpHandler) GetHolders(ctx *fiber.Ctx) (err error) { | |||
| var ok bool | |||
| runeId, ok = h.resolveRuneId(ctx.UserContext(), req.Id) | |||
| if !ok { | |||
| return errs.NewPublicError("unable to resolve rune id from \"id\"") | |||
| return errs.NewPublicError(fmt.Sprintf("unable to resolve rune id \"%s\" from \"id\"", req.Id)) | |||
|
|
||
| terms := lo.FromPtr(runeEntry.Terms) | ||
|
|
||
| result := &getTokenInfoResult{ |
There was a problem hiding this comment.
should we extract mapper func ?
Planxnx
approved these changes
Oct 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Get Token Info/Get Token Info Batch/Get Tokens.false, instead oftrue(current behavior)Type of change
What types of changes does your code introduce to Appium?
Put an
xin the boxes that applyCommit formatting
Please follow the commit message conventions for an easy way to identify the purpose or intention of a commit. Check out our commit message conventions in the CONTRIBUTING.md